Changed "Portfolio" to "Orders" #3136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The word "Portfolio" makes absolutely no sense at the menu when it's only supposed to show the open/closed orders. The portfolio usually refers to the distribution of your OWN funds, that you're not trading. It makes no sense at this point and it should be renamed as "Orders".
ManfredKarrer
suggested changes
Aug 25, 2019
There was a problem hiding this comment.
NACK
Trades are not orders and we intentionally do not use the domain language from centralized exchanged where orders get executed by a matching engine. Bisq does not work like that. Also what you edited is not the app code but a demo class as the name suggests.
|
Hmmm... it'll remain quite confusing for anyone who jumps from a centralized exchange to Bisq, but anyways, you do have a good point there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The word "Portfolio" makes absolutely no sense at the menu when it's only supposed to show the open/closed orders. The portfolio usually refers to the distribution of your OWN funds, that you're not trading. It makes no sense at this point and it should be renamed as "Orders".