Extract helper classes from BSFormatter #3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 11, 2019 15:58
All methods that are only used in the desktop project are removed from BSFormatter to DisplayUtils. This reduces the entanglement between the desktop and core project by reducing the surface area of the coupling.
Parsing and formatting are 2 different concerns, its better to have 2 classes that handle these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step in removing BSFormatter. Here I extract 2 classes.
DisplayUtils which lives in the desktop project and has all methods that are only used in desktop. This is to reduce the number of dependencies going from desktop -> core.
ParsingUtils which has all the parsing related methods (ie is not formatting).
Link to tracking issue #3240