Hide avoid standby mode feature on *nux OS #3322
Conversation
There was a problem hiding this comment.
Missing adjustment of num rows.
TitledGroupBg titledGroupBg = addTitledGroupBg(root, gridRow, 8, Res.get("setting.preferences.general")); -> 8 need to be 7 in case its not displayed
Is it confirmed that on Unix there is no need for the hack with playing the sound to avoid standby?
Displays standby mode button on only on Windows and OSX, and hides it on Linux and Unix distributions. TitledGroupBg num rows reduced to 7 when standby mode button is not displayed. Formatted source file, resulting in rearranged class level field declarations. Fix for Issue bisq-network#3223
ghubstan
force-pushed
the
hide-linux-standby-button
branch
from
ddfed2d
to
7c517dd
Compare
|
@chimp1984, the row adjustment fix has been committed. I have not confirmed there is no need for the Unix sound hack. Can @wiz or @niyid confirm there is no need for the Unix sound hack? |
| private final Preferences preferences; | ||
| private final FeeService feeService; | ||
| //private final ReferralIdService referralIdService; | ||
| private final AssetService assetService; | ||
| private final FilterManager filterManager; | ||
| //private ComboBox<BaseCurrencyNetwork> selectBaseCurrencyNetworkComboBox; | ||
| private final DaoFacade daoFacade; | ||
| private final BSFormatter formatter; | ||
| private final boolean daoOptionsSet; | ||
| private final boolean displayStandbyModeFeature; |
There was a problem hiding this comment.
please do not commit non-changes. makes it hard to review and introduces unnecessary big change sets.
There was a problem hiding this comment.
I don't understand. Are the non-changes you mentioned references to the comments (lines 103, 106)? Those were there from previous commits (before this PR). I did not add these comments. Should I delete them?
Or, are you referring to the Intellij code reformatting which rearranged the order of field definitions? I have been reformatting files I touch, using the IDE code style versioned in git. Should I not do that?
There was a problem hiding this comment.
Or, are you referring to the Intellij code reformatting which rearranged the order of field definitions? I have been reformatting files I touch, using the IDE code style versioned in git. Should I not do that?
that is what I meant. please only commit changes that have something to do with the topic of your PR. Thanks!
Displays standby mode button on only on Windows and OSX, and hides it on Linux and Unix distributions. TitledGroupBg num rows reduced to 7 when standby mode button is not displayed. Fixes bisq-network#3223 Replaces PR bisq-network#3322 -- rejected because source file reformat rearanged class level field declarations, making review more difficult.
* Hide avoid standby mode feature on *nux OS Displays standby mode button on only on Windows and OSX, and hides it on Linux and Unix distributions. TitledGroupBg num rows reduced to 7 when standby mode button is not displayed. Fixes #3223 Replaces PR #3322 -- rejected because source file reformat rearanged class level field declarations, making review more difficult. * Set use standby mode to false on non Win, OSX desktops
Displays standby mode button on only on Windows and OSX,
and hides it on Linux and Unix distributions.
Formatted source file, resulting in rearranged class
level field declarations.
Fix for Issue #3223