Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added interface and corresponding implementation to handle display of exceptions on failed vote reveal transaction #3431

Closed
wants to merge 1 commit into from
Closed

Added interface and corresponding implementation to handle display of exceptions on failed vote reveal transaction #3431

wants to merge 1 commit into from

Conversation

niyid
Copy link
Contributor

@niyid niyid commented Oct 19, 2019 •
edited by freimair

Fixes issue #3408

EDIT: fixes #3408

freimair
freimair suggested changes Nov 1, 2019
View reviewed changes
Copy link
Member

@freimair freimair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please clean up your commit history. There are three commits that add a comment, change it and then change it back.

Furthermore, please rebase your actual changes onto master instead of merging master into your feature branch

@niyid niyid requested a review from freimair November 1, 2019 14:42
@freimair
Copy link
Member

freimair commented Nov 9, 2019

please implement the requested changes. thanks!

@niyid
Copy link
Contributor Author

niyid commented Nov 9, 2019 •
edited

please implement the requested changes. thanks!

Done. Thanks for your patience. I somehow missed your previous requests.

Rebased and commits squashed.

Regards.

@ripcurlx
Copy link
Member

@niyid Please sign all your commits.

@freimair
Copy link
Member

Rebased and commits squashed.

... and push your contributions. Seems like you only did your changes locally.

@niyid
Added interface and corresponding implementation to handle display of
d1daaf3 
exceptions on failed vote reveal transaction - fixes issue 3408.
@ripcurlx
Copy link
Member

ripcurlx commented Dec 6, 2019 •
edited

Closing PR as it wasn't tested once.
Testing it on Regtest it crashes it is only displaying the missing resource key when a failed vote reveal transaction occurs. Please fix and re-open it again if you've tested it. Also add how you tested it in the PR description. Thanks!

@ripcurlx ripcurlx closed this Dec 6, 2019
@niyid
Copy link
Contributor Author

niyid commented Dec 6, 2019

Closing PR as it wasn't tested once.
Testing it on Regtest it crashes it is only displaying the missing resource key when a failed vote reveal transaction occurs. Please fix and re-open it again if you've tested it. Also add how you tested it in the PR description. Thanks!

Great! Thanks for the feedback. THe resource key must have gotten missing during a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx Awaiting requested review from ripcurlx

@sqrrm sqrrm Awaiting requested review from sqrrm

@freimair freimair Awaiting requested review from freimair

Assignees
No one assigned
Labels
was:incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vote Reveal - Silent Fail
3 participants
@niyid @freimair @ripcurlx