Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up trade statistics from duplicate entries #3476

Merged
merged 3 commits into from Oct 28, 2019
Merged

Clean up trade statistics from duplicate entries #3476

merged 3 commits into from Oct 28, 2019

Commits on Oct 26, 2019

  1. Clean up trade statistics from duplicate entries 

    At software updates we added new entries to the extraMap which caused
duplicate entries (if one if the traders was on the new and the other on
the old version or at republishing). We set it now json exclude so avoid
that in future and clean up the map.
    @chimp1984
    chimp1984 committed Oct 26, 2019
    Copy the full SHA
    14924fc View commit details
    Browse the repository at this point in the history

  2. Avoid repeated calls to addPersistableNetworkPayloadFromInitialRequest 

    For trade stat cleanup we don't want to apply it multiple times as it
is a bit expensive. We get from each seed node the initial data response
and would pollute with the second response our map again and if our node
is a seed node, the seed node itself could not get into a clean state and
would continue pollution other nodes.
    @chimp1984
    chimp1984 committed Oct 26, 2019
    Copy the full SHA
    4a61e28 View commit details
    Browse the repository at this point in the history

  3. Refactor 

    Remove not used param
Rename method
Inline method
Cleanups
    @chimp1984
    chimp1984 committed Oct 26, 2019
    Copy the full SHA
    2ffca0d View commit details
    Browse the repository at this point in the history