[1.2.0] Check for result phase at activate method #3492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2019
devinbileck
suggested changes
Oct 28, 2019
| fillCycleList(); | ||
| } | ||
|
|
||
| private void checkForResultPhase(int chainHeight) { | ||
| if (periodService.getFirstBlockOfPhase(chainHeight, DaoPhase.Phase.RESULT) == chainHeight) { |
There was a problem hiding this comment.
Shouldn't this be <= chainHeight?
There was a problem hiding this comment.
periodService.getFirstBlockOfPhase gets the height of the first block of the current phase so this check will return true for all chainHeight in the RESULT phase.
sqrrm
approved these changes
Oct 28, 2019
| fillCycleList(); | ||
| } | ||
|
|
||
| private void checkForResultPhase(int chainHeight) { | ||
| if (periodService.getFirstBlockOfPhase(chainHeight, DaoPhase.Phase.RESULT) == chainHeight) { |
There was a problem hiding this comment.
periodService.getFirstBlockOfPhase gets the height of the first block of the current phase so this check will return true for all chainHeight in the RESULT phase.
ripcurlx
changed the title
|
@sqrrm I think you approved by mistake -> NACK |
|
I first approved without testing. Then I read a bit more, checked out and tested and it fails, working on a fix. Don't know how to undo the approve. |
|
I made a new PR at #3500 that fixes this |
|
Superseded by #3500 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3487