Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing network capability for trade statistics hash update #3551

Merged
merged 1 commit into from Nov 4, 2019

Conversation

@ripcurlx
Copy link
Member

ripcurlx commented Nov 4, 2019

I think we missed to add the new statistics hash capability to the core network capabilities.
At least this worked for me in my local nodes when I recognized some missing trade statistics.

@ripcurlx

This comment has been minimized.

Copy link
Member Author

ripcurlx commented Nov 4, 2019

@chimp1984 @sqrrm Could you review if my finding is correct?

@sqrrm

This comment has been minimized.

Copy link
Member

sqrrm commented Nov 4, 2019

I think you're right. I don't have the time right now to test it though.

@ripcurlx

This comment has been minimized.

Copy link
Member Author

ripcurlx commented Nov 4, 2019

I think you're right. I don't have the time right now to test it though.

It did solve the problem on two of my nodes. Unfortunately during my release smoke test I got two runtime trade stats for 1st of Nov and I thought everything is right now and we just didn't have any trades the day before because everyone was updating and too afraid to trade during this transitional period.

@ripcurlx

This comment has been minimized.

Copy link
Member Author

ripcurlx commented Nov 4, 2019

Tested it now on three different live nodes and it seems to work now. Just waiting for an ACK from someone else. Also we need to decide if we want to shoot out another release soon (latest on Thursday).

Copy link
Member

freimair left a comment

Ack.

Assuming that without this fix, a fresh client would not get all trade stats on startup, I just fired up a fresh 1.2.2 instance and compared the trade stats with my alway-on instance. All trades are there. 26 trades on 2019-11-01.

@freimair freimair referenced this pull request Nov 4, 2019
Copy link
Contributor

chimp1984 left a comment

utACK

@ripcurlx ripcurlx merged commit 33c9dd1 into bisq-network:master Nov 4, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx ripcurlx referenced this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.