Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add command for signing windows executables with the default code signing certificate #3772
In my role as Bisq desktop maintainer and release manager I applied for a personal code signing certificate for
To test the behavior of a signed Windows executable you'll actually need a Windows machine to do so.
Posting my results here.
As mentioned here:
I am not sure if the EV certificate is worth the hassle, nor am I sure how long it would take to develop reputation with the standard certificate.
Besides being more expensive an EV certificate has stronger KYC requirements. I have to have a look how difficult it would be to get one based on the existing code certificate I already have.
Regarding reputation it seems you get it e.g. by getting signed applications installed. So I think maybe we could start with the current code signing certificate to see if it would gain enough reputation already after the next round of updates. @devinbileck What do you think?
devinbileck left a comment •
I am not able to test with a signing certificate, but when attempting to run the script without it, I encounter the following error and the script still completes.
That seems reasonable to me. That way anyone can still run the script to generate an installer without requiring a signing certificate.