Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double presence of the word "days" #3804

Merged
merged 1 commit into from Dec 19, 2019

Conversation

@SimoneBovi
Copy link
Contributor

SimoneBovi commented Dec 18, 2019

When Alice tries to takes an offer that can't take, she receives the following message:

Screenshot 2019-12-18 at 16 54 26

As you can see, there is a double occurrence of the word "days". This PR should fix that as shown below.

Screenshot 2019-12-18 at 17 04 26

I thought it was easier to change the string in the properties file, if you think it is better to change in the Java code instead, let me know.

@SimoneBovi SimoneBovi requested a review from ripcurlx as a code owner Dec 18, 2019
Copy link
Member

ripcurlx left a comment

utACK on the code changes. Removing it from the translations file is the right thing to do in that case.

NACK - as you need to sign your commits https://help.github.com/en/github/authenticating-to-github/signing-commits

@SimoneBovi SimoneBovi force-pushed the SimoneBovi:days_repeated branch from 60836af to 4b68f45 Dec 19, 2019
@SimoneBovi SimoneBovi requested a review from ripcurlx Dec 19, 2019
@ripcurlx ripcurlx merged commit 334ebfc into bisq-network:master Dec 19, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SimoneBovi

This comment has been minimized.

Copy link
Contributor Author

SimoneBovi commented Dec 19, 2019

My first merged PR, so happy :)

@SimoneBovi SimoneBovi deleted the SimoneBovi:days_repeated branch Dec 19, 2019
@ripcurlx ripcurlx added this to the v1.2.5 milestone Jan 2, 2020
@ripcurlx ripcurlx mentioned this pull request Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.