Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display minimum limit if used during trade #3870

Merged
merged 5 commits into from Jan 7, 2020
Merged

Display minimum limit if used during trade #3870

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
02ac14e
Use trading fee in BSQ fee comparison
ripcurlx Jan 7, 2020
e6f491c
Add information if minimum trading fee or minimum security deposit is…
ripcurlx Jan 7, 2020
d904d1e
Show minimum security deposit in create offer dialog when used
ripcurlx Jan 7, 2020
b9d51ca
Only validate security deposit amount if used
ripcurlx Jan 7, 2020
e7c16a6
Use general "(required minimum)" label with BTC value if min value is…
ripcurlx Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java
View file
Open in desktop
Expand Up @@ -1221,13 +1221,17 @@ private void updateButtonDisableState() {
boolean inputDataValid = isBtcInputValid(amount.get()).isValid &&
isBtcInputValid(minAmount.get()).isValid &&
isPriceInputValid(price.get()).isValid &&
securityDepositValidator.validate(buyerSecurityDeposit.get()).isValid &&
dataModel.getPrice().get() != null &&
dataModel.getPrice().get().getValue() != 0 &&
isVolumeInputValid(volume.get()).isValid &&
isVolumeInputValid(DisplayUtils.formatVolume(dataModel.getMinVolume().get())).isValid &&
dataModel.isMinAmountLessOrEqualAmount();

// validating the percentage deposit value only makes sense if it is actually used
if (!dataModel.isMinBuyerSecurityDeposit()) {
inputDataValid = inputDataValid && securityDepositValidator.validate(buyerSecurityDeposit.get()).isValid;
}

isNextButtonDisabled.set(!inputDataValid);
// boolean notSufficientFees = dataModel.isWalletFunded.get() && dataModel.isMainNet.get() && !dataModel.isFeeFromFundingTxSufficient.get();
//isPlaceOfferButtonDisabled.set(createOfferRequested || !inputDataValid || notSufficientFees);
Expand Down