Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tableview multiple rows checkbox column issue #4008

Merged
merged 1 commit into from Feb 26, 2020

Conversation

@beingindot
Copy link
Contributor

beingindot commented Feb 25, 2020

Fixes #3984

As mentioned in the issue #3984, Have created lot of buy/sell offers with different currencies spanning across around 30+ offers.
so that we need to use scroll bar in my open offers section and able to recreate the issue.

As mentioned in the issue #3984, Have created lot of buy/sell offers
with different currencies spanning across around 30+ offers
so that we need to use scroll bar in my open offers and able to
recreate the issue.
@beingindot beingindot requested a review from ripcurlx Feb 25, 2020
Copy link
Member

ripcurlx left a comment

ACK

Tested it on local Regtest having more than 30 offers (scrolling is required) and when changing the enabled state of a single offer at the bottom the visual representation of other offers is changed as well. The state itself doesn't change just the rendering is wrong. Using the code in this PR fixes this problem

@ripcurlx ripcurlx merged commit bf592f3 into bisq-network:master Feb 26, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx ripcurlx added this to the v1.2.8 milestone Feb 26, 2020
@beingindot beingindot mentioned this pull request Mar 12, 2020
@ripcurlx ripcurlx mentioned this pull request Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.