Tableview multiple rows checkbox column issue #4008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in the issue bisq-network#3984, Have created lot of buy/sell offers with different currencies spanning across around 30+ offers so that we need to use scroll bar in my open offers and able to recreate the issue.
ripcurlx
added
the
is:priority
ripcurlx
approved these changes
Feb 26, 2020
There was a problem hiding this comment.
ACK
Tested it on local Regtest having more than 30 offers (scrolling is required) and when changing the enabled state of a single offer at the bottom the visual representation of other offers is changed as well. The state itself doesn't change just the rendering is wrong. Using the code in this PR fixes this problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3984
As mentioned in the issue #3984, Have created lot of buy/sell offers with different currencies spanning across around 30+ offers.
so that we need to use scroll bar in my open offers section and able to recreate the issue.