Revert to only check local BTC node's port #4067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing showed that the new mechanic for checking a local BTC node's configuration is unstable. This commit reverts to just checking if the relevant port is open. The recent refactoring and centralization of logic is still in place.
ripcurlx
previously approved these changes
Mar 16, 2020
|
Waiting for another ACK by @wiz until I merge and cherry-pick it into the v1.2.9 release branch |
wiz
previously approved these changes
Mar 16, 2020
sqrrm
reviewed
Mar 16, 2020
| popup.warning.localNodeMisconfigured.explanation=Bisq detected a locally running Bitcoin Core node (at localhost); however, its configuration is incompatible with Bisq.\n\n\ | ||
| For Bisq to use a local Bitcoin node, the node has to have pruning disabled and bloom filters enabled. Starting with Bitcoin Core v0.19 you have to manually enable bloom filters by setting peerbloomfilters=1 in your bitcoin.conf configuration file. | ||
| popup.warning.localNodeMisconfigured.continueWithoutLocalNode=Continue without using local node | ||
|
|
||
| popup.bitcoinLocalhostNode.msg=Bisq detected a locally running Bitcoin Core node (at localhost) and is using it.\n\ | ||
| Please make sure that this node is fully synced before you start Bisq. | ||
| popup.bitcoinLocalhostNode.additionalRequirements=\n\nThe node was found to be well configured. For reference, the requirements are for the node to have pruning disabled and bloom filters enabled. |
There was a problem hiding this comment.
Should this message remain without the proper check?
There was a problem hiding this comment.
Didn't notice that. Should be changed. Have to go out for an hour; will change it when I come back.
There was a problem hiding this comment.
Good catch - this should be in that case
Suggested change
| popup.bitcoinLocalhostNode.additionalRequirements=\n\nThe node was found to be well configured. For reference, the requirements are for the node to have pruning disabled and bloom filters enabled. | |
| popup.bitcoinLocalhostNode.additionalRequirements=\n\nStarting with Bitcoin Core v0.19 you have to manually enable bloom filters by setting peerbloomfilters=1 in your bitcoin.conf configuration file. |
sqrrm
reviewed
Mar 16, 2020
ripcurlx
reviewed
Mar 16, 2020
Co-Authored-By: sqrrm <sqrrm@users.noreply.github.com>
|
@dmos62 I already committed the change suggestions |
ripcurlx
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert to only check local BTC node's port
Testing showed that the new mechanic for checking a local BTC node's
configuration is unstable. This commit reverts to just checking if the
relevant port is open. The recent refactoring and centralization of
logic is still in place.
Supersedes PR #4062.