Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BuyerVerifiesDonationAddress task #4131

Closed
wants to merge 1 commit into from
Closed

Add BuyerVerifiesDonationAddress task #4131

wants to merge 1 commit into from

Conversation

burningman2
Copy link

@burningman2 burningman2 commented Apr 7, 2020 •
edited

No description provided.

@chimp1984
Add BuyerVerifiesDonationAddress task
956cb65 
Buyer was not verifying if the donation address is either the default
DAO param address or the recent one changed by DAO voting. We do not
support past DAO param addresses to avoid that past addresses receive
funds.
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 7, 2020

Thanks for opening this pull request!

Please check out our contributor checklist and check if Travis or Codacy found any issues with your PR. Also make sure your commits are signed, and that you applied Bisq's code style and formatting.

A maintainer will add an is:priority label to your PR if it is up for compensation. Please see our Bisq Q1 2020 Update post for more details.

This was referenced Apr 7, 2020
Closed
Closed
@burningman2 burningman2 closed this Apr 7, 2020
@burningman2 burningman2 changed the title Add BuyerVerifiesDonationAddress task .... Apr 7, 2020
@burningman2 burningman2 changed the title .... Add BuyerVerifiesDonationAddress task Apr 7, 2020
@chimp1984 chimp1984 deleted the add-donation-address-verification-to-buyer branch April 8, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@burningman2 @chimp1984