Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn that seeds are not a data backup #4379

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 27, 2020

Display a mandatory warning when the seed backup/restore screen is shown. The warning informs the user that a data directory backup is necessary to restore the full state of bisq, not just the wallet seed words.

Fixes #4375

Screenshot:

image

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK - Just some minor code changes to make the refactoring more verbose. Besides that 👍

Display a mandatory warning when the seed backup/restore
screen is shown.  The warning informs the user that a data
directory backup is necessary to restore the full state of
bisq, not just the wallet seed words.

Fixes #4375
@ghost
Copy link
Author

ghost commented Jul 27, 2020

Made the suggested review changes, and updated the popup to include a Don't show again checkbox. See updated screenshot above.

@ghost ghost requested a review from ripcurlx July 27, 2020 15:51
@ripcurlx ripcurlx merged commit 34f26b1 into bisq-network:master Jul 27, 2020
@ripcurlx ripcurlx added this to the v1.3.7 milestone Jul 29, 2020
@ghost ghost mentioned this pull request Aug 20, 2020
@ghost ghost deleted the fix_popups branch December 3, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve warning about seeds are not a data backup.
1 participant