Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header and other visual tweaks #4398

Merged
merged 2 commits into from Aug 24, 2020
Merged

Conversation

pedromvpg
Copy link
Member

Reduce header visual elements and prevent it from over growing when client widow goes wider.
More minimal and flatter look to keep it current with the times! 馃捀

Screen Shot 2020-08-04 at 1 54 01 AM

Screen Shot 2020-08-04 at 1 53 55 AM

@ripcurlx
Copy link
Member

ripcurlx commented Aug 5, 2020

Just tried to re-trigger the build as I had the line length configured wrong. 80 instead of 90 chars

@pedromvpg
Copy link
Member Author

Any action needed on my end?

@ripcurlx
Copy link
Member

Any action needed on my end?

You could try a force push to re-trigger the codacy checks, otherwise I'll do it on Tuesday.

@ripcurlx
Copy link
Member

Any action needed on my end?

@pedromvpg As I'm not able to push to your repo (because of git lfs issues batch response: You need Push access to upload Git LFS objects. error: failed to push some refs to 'https://github.com/pedromvpg/bisq.git'), could you please run following in your terminal?

git commit --amend -m "Shorten line length" to fix your last commit message and afterwards git push --force. That should re-trigger the Codacy validation.

@pedromvpg
Copy link
Member Author

Done

$ git commit --amend -m "Shorten line length"
[header-tweaks b1d4a41a8] Shorten line length
Date: Wed Aug 5 14:59:19 2020 -0400
1 file changed, 6 insertions(+), 4 deletions(-)

And done

$ git push --force
Enumerating objects: 19, done.
Counting objects: 100% (19/19), done.
Delta compression using up to 16 threads.
Compressing objects: 100% (8/8), done.
Writing objects: 100% (10/10), 782 bytes | 782.00 KiB/s, done.
Total 10 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4), completed with 4 local objects.
To ssh://github.com/pedromvpg/bisq
+ 48f1c9021...b1d4a41a8 header-tweaks -> header-tweaks (forced update)

@ripcurlx
Copy link
Member

馃ぃ Now Travis had issues during the build. I just re-triggered the JDK 12 test.

ripcurlx
ripcurlx previously approved these changes Aug 24, 2020
Copy link
Member

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ripcurlx
Copy link
Member

Done

$ git commit --amend -m "Shorten line length"
[header-tweaks b1d4a41a8] Shorten line length
Date: Wed Aug 5 14:59:19 2020 -0400
1 file changed, 6 insertions(+), 4 deletions(-)

And done

$ git push --force
Enumerating objects: 19, done.
Counting objects: 100% (19/19), done.
Delta compression using up to 16 threads.
Compressing objects: 100% (8/8), done.
Writing objects: 100% (10/10), 782 bytes | 782.00 KiB/s, done.
Total 10 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4), completed with 4 local objects.
To ssh://github.com/pedromvpg/bisq
+ 48f1c9021...b1d4a41a8 header-tweaks -> header-tweaks (forced update)

@pedromvpg Your last commit wasn't signed.

Copy link
Member

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ripcurlx ripcurlx merged commit 30eeb6e into bisq-network:master Aug 24, 2020
@wiz
Copy link
Member

wiz commented Aug 29, 2020

@pedromvpg @ripcurlx I guess you guys only tested this on English because it totally breaks the Japanese top GUI layout. I made a PR #4448 to revert it for now. Pedro, let's work together testing your next PR with all languages :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants