Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate CompositeOptionSet class #4428

Merged
merged 1 commit into from Aug 25, 2020

Conversation

ghubstan
Copy link
Member

This commit changes the access modifier on bisq.common.config.CompositeOptionSet to make it visible to bisq.apitest.config.ApiTestConfig, and the duplicate bisq.apitest.config.ApiTestConfig was deleted from 'apitest'.

This PR replaces 4417.

This commit changes the access modifier on
bisq.common.config.CompositeOptionSet to make
it visible to bisq.apitest.config.ApiTestConfig,
and the duplicate bisq.apitest.config.ApiTestConfig
was deleted from 'apitest'.
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit f45a26c into bisq-network:master Aug 25, 2020
Ship Bisq Daemon and API automation moved this from In progress to Done Aug 25, 2020
@ripcurlx ripcurlx added this to the v1.3.8 milestone Aug 29, 2020
@ghubstan ghubstan deleted the rm-duplicate-compositeoptset branch September 1, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants