New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle messages at broadcast #4436
Bundle messages at broadcast #4436
Commits on Aug 24, 2020
Commits on Aug 27, 2020
-
- Add shutdown handling to broadCaster.
It is important that we flush our queued requests at shutdown and wait until broadcast is completed as a maker need to remove his offers at shutdown. - Add handling for the case that there are very few connections (as in dev setup). - Make BundleOfEnvelopes extend BroadcastMessage - Add complete handler for broadCaster to shutdown in P2PService and wait with shutdown of other services until broadcaster is completed. - Remove case for repeated shutdown call on P2PService as it cannot happen.
-
-
Commits on Aug 28, 2020
Commits on Aug 29, 2020
-
Merge branch 'master_upstream' into bundle-msg-at-broadcast
# Conflicts: # p2p/src/main/java/bisq/network/p2p/P2PService.java
-
Merge remote-tracking branch 'origin/bundle-msg-at-broadcast' into bu…
…ndle-msg-at-broadcast # Conflicts: # p2p/src/main/java/bisq/network/p2p/P2PService.java
Commits on Aug 30, 2020
-
Merge branch 'master_upstream' into bundle-msg-at-broadcast
# Conflicts: # p2p/src/main/java/bisq/network/p2p/P2PService.java
-
Merge remote-tracking branch 'origin/bundle-msg-at-broadcast' into bu…
…ndle-msg-at-broadcast
-
-
I don't know why the tests failed as I just added an overloaded method and it should not have any impact. There is also one exception which makes it even more obscure. I guess its some test framework issue. See comment at the exceptional handling // If we remove the last argument (isNull()) tests fail. No idea why as the broadcast method has an / overloaded method with nullable listener. Seems a testframework issue as it should not matter if the // method with listener is called with null argument or the other method with no listener. We removed the // null value from all other calls but here we can't as it breaks the test.