Use InetAddress.getLoopbackAddress instead of InetAddress.getLocalHost() #4466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On OSX InetAddress.getLocalHost() can cause problems. On my machine I get a 5 sec. delay at each start up in localhost mode. The InetAddress.getLoopbackAddress call is super fast. Both versions connect to my local btc node, but not sure what can be the differences if local environment is configured differently as default. But as those issues with very slow getLocalHost lookup seems to be more risky I would recommend that we change it. It only affects localhost regtest mode and users who have a local btc node running. The detection code for that is using getLoopbackAddress as well. See: bisq-network@a5cca0e
|
I would advice to always use 127.0.0.1 to connect to local running services. |
|
Thanks @Emzy . Then the getLoopbackAddress is the right approach. Was also changed to that in the local node detection code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OSX InetAddress.getLocalHost() can cause problems. On my machine I
get a 5 sec. delay at each start up in localhost mode. The
InetAddress.getLoopbackAddress call is super fast.
Both versions connect to my local btc node, but not sure what can be
the differences if local environment is configured differently as
default. But as those issues with very slow getLocalHost lookup seems
to be more risky I would recommend that we change it.
It only affects localhost regtest mode and users who have a local btc
node running. The detection code for that is using getLoopbackAddress
as well.
See: a5cca0e