Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note to SetXmrTxKeyWindow #4497

Merged
merged 1 commit into from Sep 8, 2020
Merged

Add note to SetXmrTxKeyWindow #4497

merged 1 commit into from Sep 8, 2020

Conversation

m52go
Copy link
Contributor

@m52go m52go commented Sep 7, 2020 •
edited

This PR adds a small note on the SetXmrTxKeyWindow about auto-confirm, and it makes clear that the inputs for tx info are optional.

Before:

Screenshot from 2020-09-07 11-43-56

After:

Screenshot from 2020-09-07 11-33-13

Add note to SetXmrTxKeyWindow
2265d8f 
To convey what it's about, and that it's optional.
chimp1984
chimp1984 approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

ripcurlx
ripcurlx approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ripcurlx ripcurlx merged commit d73a284 into bisq-network:master Sep 8, 2020
@ripcurlx ripcurlx added this to the v1.3.8 milestone Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

@chimp1984 chimp1984 chimp1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@m52go @ripcurlx @chimp1984