Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resource files tagged by version to reduce initial data requests #4519

Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
94 commits
Select commit Hold shift + click to select a range
cb9f0f0
Initial tests
freimair Apr 9, 2020
3296db3
Version helper uses real Bisq version
freimair Apr 15, 2020
e7831d6
Tests use static fixtures
freimair Apr 16, 2020
581286e
Migration test succeeds
freimair Apr 16, 2020
fc7a43d
GetMap test succeeds
freimair Apr 16, 2020
d111d8c
GetMapSinceFilter works
freimair Apr 16, 2020
6eda9a9
updateScenario works
freimair Apr 16, 2020
ff53f51
freshInstall scenario works
freimair Apr 16, 2020
49731f9
put scenario works
freimair Apr 16, 2020
e123a0b
Introduce SplitStore and Service to handle BL
freimair Apr 17, 2020
da5d41b
Moved file handling logic to SplitStoreService
freimair Apr 17, 2020
c7351a0
Activate other split data stores
freimair Apr 17, 2020
e2e80d7
Refactored tests
freimair Apr 20, 2020
10c1ecc
Initial tests for requests
freimair Apr 20, 2020
f6cea15
Requests are smaller
freimair Apr 20, 2020
0d80123
Prevent adding duplicate data
freimair Apr 24, 2020
aad57c3
Enforce version format and filter faulty ones
freimair Apr 24, 2020
faca8e4
Test incoming special keys from the future
freimair Apr 24, 2020
72600b1
Javadoc cosmetics
freimair Apr 24, 2020
3ad395b
Init integration test script
freimair Apr 29, 2020
2589137
Persist live database after split
freimair May 1, 2020
34abad0
Integration test script tests stock
freimair May 1, 2020
62a77e3
Use version history array
freimair May 1, 2020
39fcca5
Integration test script tests new system
freimair May 4, 2020
a3628ff
Use full sync between seednodes
freimair May 4, 2020
a374249
Cleanup integration test script
freimair May 4, 2020
8e55f64
Ignore some tests
freimair May 11, 2020
e927e6d
Adjust P2PDataStorage tests
freimair May 11, 2020
2fb2232
Add another migration test
freimair May 12, 2020
5f8b7cf
Reactivate ignored tests
freimair May 12, 2020
f8320fe
Refactoring and cleaning up
freimair May 20, 2020
017bbfd
Cleanup
freimair May 20, 2020
d2a6655
Refactored test helpers
freimair May 21, 2020
469c374
Fixed a potential issue when loading stores
freimair May 21, 2020
249e185
Fixed wrong filename
freimair May 22, 2020
06ec223
Refactoring
freimair May 22, 2020
eabadc0
Make special key platform-independent
freimair May 26, 2020
755fc03
Fixed persisting wrong data store
freimair Jun 12, 2020
d218f2e
Renamed data stores
freimair Jun 12, 2020
c34bfee
Replace TODO comment
freimair Jun 16, 2020
d6f195d
Fixed a timing issue
freimair Jul 1, 2020
d81bdab
Added 1.3.6 and 1.3.7 data stores
freimair Sep 1, 2020
abbfedc
Update history version list
freimair Sep 1, 2020
5f94406
Removed deprecated test mechanisms
freimair Sep 1, 2020
0eccec7
Cleanup imports
freimair Sep 1, 2020
270f1e7
Included PR feedback
freimair Sep 1, 2020
c8c63ef
Included PR feedback
freimair Sep 1, 2020
76cc37e
Added 1.3.8 data stores
freimair Sep 12, 2020
b4aae51
Use Version.VERSION again
freimair Sep 12, 2020
f83c147
Merge branch 'master_upstream' into chimp-reduce_initial_request_size
chimp1984 Sep 13, 2020
5f8e779
Refactor: Add getStore method to be reused by SplitStoreService
chimp1984 Sep 13, 2020
3100888
Use readStore(); instead of store = readStore(getFileName());
chimp1984 Sep 13, 2020
591c2fb
Apply code inspection suggestions
chimp1984 Sep 13, 2020
d5c6644
Add mapOfHistoricalStores field
chimp1984 Sep 13, 2020
3dac4c4
Revert critical data stores to current version.
chimp1984 Sep 13, 2020
2cef411
Add version field
chimp1984 Sep 13, 2020
8458a88
Remove methods in MapStoreService and do instead instance of check in…
chimp1984 Sep 13, 2020
2ece512
Add current version to version list. Makes it more clear that those a…
chimp1984 Sep 13, 2020
965de7f
Remove file
chimp1984 Sep 13, 2020
cfefae2
Rename SplitStore to PersistableNetworkPayload
chimp1984 Sep 13, 2020
28987f5
Rename for better clarity
chimp1984 Sep 13, 2020
6cf054c
Fix bug with missing replace -> use existing methods in Version for v…
chimp1984 Sep 13, 2020
aadd2e4
Revert version to 1.3.7 to not break build
chimp1984 Sep 13, 2020
7a5ba0b
Fix param in test. Add Ignore to the 2 test classes handling the new …
chimp1984 Sep 13, 2020
224eaab
Fix param in test.
chimp1984 Sep 13, 2020
98877b4
Revert changes at tests from prev version
chimp1984 Sep 13, 2020
32cf32c
Merge branch 'master_upstream' into chimp-reduce_initial_request_size
chimp1984 Sep 15, 2020
8f2e4ca
Change dev mode price
chimp1984 Sep 15, 2020
22fc97d
Remove test files from previous version
chimp1984 Sep 16, 2020
9c873a6
Add getPersisted method
chimp1984 Sep 16, 2020
3252a50
remove test files
chimp1984 Sep 16, 2020
a3ea54a
remove test
chimp1984 Sep 16, 2020
2b61563
Fix issues and refactor
chimp1984 Sep 16, 2020
996364e
Cleanup
chimp1984 Sep 16, 2020
4115c0c
Add data from non-splitStoreService as well
chimp1984 Sep 16, 2020
ad95019
Merge branch 'master_upstream' into chimp-reduce_initial_request_size
chimp1984 Sep 17, 2020
e680c4d
Merge branch 'master_upstream' into chimp-reduce_initial_request_size
chimp1984 Sep 19, 2020
80bf8bf
Merge branch 'master_upstream' into chimp-reduce_initial_request_size
chimp1984 Sep 27, 2020
3a4784e
Merge branch 'chimp-reduce_initial_request_size' of https://github.co…
chimp1984 Sep 27, 2020
c482a1b
Cleanups, renaming, add comments
chimp1984 Sep 27, 2020
ba0dc1b
Fix mock class to reflect real class better.
chimp1984 Sep 28, 2020
f132a35
Fix incorrect test.
chimp1984 Sep 28, 2020
6eb1efb
Remove todo, add system line break
chimp1984 Sep 28, 2020
ee725bc
Add more logs
chimp1984 Sep 28, 2020
82c5b5e
Add isEmpty check
chimp1984 Sep 29, 2020
171be24
Do not call super.readFromResources(postFix); as we do not have a no…
chimp1984 Sep 29, 2020
bd38097
Add more logs
chimp1984 Sep 29, 2020
0feece6
Remove toProtoNetworkEnvelope call used only for debug logs
chimp1984 Sep 29, 2020
e402c8a
Only call pruneStore if we have created a new historical store from r…
chimp1984 Sep 29, 2020
620dfca
Fix wrong param order in log
chimp1984 Sep 29, 2020
90da37f
Remove dev test data
chimp1984 Sep 29, 2020
9240eec
Add more info in log
chimp1984 Sep 29, 2020
ab82286
Rename SplitStoreService to HistoricalDataStoreService
chimp1984 Sep 29, 2020
f2cc5a6
Merge branch 'master_upstream' into wip-merge
chimp1984 Oct 1, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions build.gradle
Expand Up @@ -376,7 +376,7 @@ configure(project(':desktop')) {
apply plugin: 'witness'
apply from: '../gradle/witness/gradle-witness.gradle'

version = '1.3.8'
version = '1.3.7'

mainClassName = 'bisq.desktop.app.BisqAppMain'

Expand Down Expand Up @@ -497,7 +497,7 @@ configure(project(':pricenode')) {

test {
useJUnitPlatform()

// Disabled by default, since spot provider tests include connections to external API endpoints
// Can be enabled by adding -Dtest.pricenode.includeSpotProviderTests=true to the gradle command:
// ./gradlew test -Dtest.pricenode.includeSpotProviderTests=true
Expand Down
4 changes: 2 additions & 2 deletions common/src/main/java/bisq/common/app/Version.java
Expand Up @@ -30,12 +30,12 @@ public class Version {
// VERSION = 0.5.0 introduces proto buffer for the P2P network and local DB and is a not backward compatible update
// Therefore all sub versions start again with 1
// We use semantic versioning with major, minor and patch
public static final String VERSION = "1.3.8";
public static final String VERSION = "1.3.7";

/**
* Holds a list of the versions of tagged resource files for optimizing the getData requests.
*/
public static final List<String> history = Arrays.asList("1.3.5", "1.3.6", "1.3.7", "1.3.8");
public static final List<String> history = Arrays.asList("1.3.5", "1.3.6", "1.3.7");

public static int getMajorVersion(String version) {
return getSubVersion(version, 0);
Expand Down
2 changes: 1 addition & 1 deletion desktop/package/linux/Dockerfile
Expand Up @@ -8,7 +8,7 @@

# pull base image
FROM openjdk:8-jdk
ENV version 1.3.8
ENV version 1.3.7

RUN apt-get update && apt-get install -y --no-install-recommends openjfx && rm -rf /var/lib/apt/lists/* &&
apt-get install -y vim fakeroot
Expand Down
2 changes: 1 addition & 1 deletion desktop/package/linux/package.sh
Expand Up @@ -6,7 +6,7 @@
# - Update version below
# - Ensure JAVA_HOME below is pointing to OracleJDK 10 directory

version=1.3.8
version=1.3.7
version_base=$(echo $version | awk -F'[_-]' '{print $1}')
if [ ! -f "$JAVA_HOME/bin/javapackager" ]; then
if [ -d "/usr/lib/jvm/jdk-10.0.2" ]; then
Expand Down
2 changes: 1 addition & 1 deletion desktop/package/linux/release.sh
Expand Up @@ -4,7 +4,7 @@
# Prior to running this script:
# - Update version below

version=1.3.8
version=1.3.7
base_dir=$( cd "$(dirname "$0")" ; pwd -P )/../../..
package_dir=$base_dir/desktop/package
release_dir=$base_dir/desktop/release/$version
Expand Down
4 changes: 2 additions & 2 deletions desktop/package/macosx/Info.plist
Expand Up @@ -5,10 +5,10 @@
<!-- See: https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html -->

<key>CFBundleVersion</key>
<string>1.3.8</string>
<string>1.3.7</string>

<key>CFBundleShortVersionString</key>
<string>1.3.8</string>
<string>1.3.7</string>

<key>CFBundleExecutable</key>
<string>Bisq</string>
Expand Down
2 changes: 1 addition & 1 deletion desktop/package/macosx/create_app.sh
Expand Up @@ -6,7 +6,7 @@ mkdir -p deploy

set -e

version="1.3.8"
version="1.3.7"

cd ..
./gradlew :desktop:build -x test shadowJar
Expand Down
2 changes: 1 addition & 1 deletion desktop/package/macosx/finalize.sh
Expand Up @@ -2,7 +2,7 @@

cd ../../

version="1.3.8"
version="1.3.7"

target_dir="releases/$version"

Expand Down
4 changes: 2 additions & 2 deletions desktop/package/macosx/replace_version_number.sh
Expand Up @@ -2,8 +2,8 @@

cd $(dirname $0)/../../../

oldVersion=1.3.7
newVersion=1.3.8
oldVersion=1.3.6
newVersion=1.3.7

find . -type f \( -name "finalize.sh" \
-o -name "create_app.sh" \
Expand Down
2 changes: 1 addition & 1 deletion desktop/package/windows/package.bat
Expand Up @@ -11,7 +11,7 @@

@echo off

set version=1.3.8
set version=1.3.7
if not exist "%JAVA_HOME%\bin\javapackager.exe" (
if not exist "%ProgramFiles%\Java\jdk-10.0.2" (
echo Javapackager not found. Update JAVA_HOME variable to point to OracleJDK.
Expand Down
2 changes: 1 addition & 1 deletion desktop/package/windows/release.bat
Expand Up @@ -6,7 +6,7 @@

@echo off

set version=1.3.8
set version=1.3.7
set release_dir=%~dp0..\..\..\releases\%version%
set package_dir=%~dp0..

Expand Down
2 changes: 1 addition & 1 deletion relay/src/main/resources/version.txt
@@ -1 +1 @@
1.3.8
1.3.7
2 changes: 1 addition & 1 deletion seednode/src/main/java/bisq/seednode/SeedNodeMain.java
Expand Up @@ -33,7 +33,7 @@

@Slf4j
public class SeedNodeMain extends ExecutableForAppWithP2p {
private static final String VERSION = "1.3.8";
private static final String VERSION = "1.3.7";
private SeedNode seedNode;

public SeedNodeMain() {
Expand Down