[WIP] Redesign persistence save to file task #4522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only set delay at initialisation - Remove queueUpForSave methods with delay param - Add saveNow method - Use longer delay values - Add shutdown method
Remove executor which got started at each save request, leading to many tasks in case that saveLater was called frequently, which is specially at startup the case. Use a periodic timer instead, makes the model much more simple. Add saveNow methods with executor as param so it can be written on synchronously on user thread as well. Add completeHandlers to the saveNow method. Add isInitialized to check if the storage is already initialized before calling queueUpForSave
chimp1984
changed the title
|
Replaced by #4527 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The model we borrowed from BitcoinJ wallet persistence comes with some complexity and performance costs if the queueUpForSave was called frequently (which is the case). We started for each queueUpForSave call a new thread and most returned without doing work if the persitable data was written by a concurrent task already.
A periodic timer task is a much more simple model. The costs for creating a new task is higher than a runnable execute without doing work in case that there was no new queueUpForSave call.
It also simplifies the usage for clients as the period for persiting is set at intitialisation and cannot be changed anymore (was a bit messy with many different delay values). The period for persistence should reflect the frequency of data changes and the importance that the data is the latest version if the user shuts down quickly.
There is now also a saveNow method in case immediate write is needed. This comes as sync or async with completeHandler so we dont need to add a safety delay before continuing (e.g. shutdown).