Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bitcoinj 0.15.8 (commit 5312aa3) #4550

Merged
merged 1 commit into from Sep 26, 2020
Merged

Use bitcoinj 0.15.8 (commit 5312aa3) #4550

merged 1 commit into from Sep 26, 2020

Conversation

oscarguindzberg
Copy link
Contributor

@oscarguindzberg oscarguindzberg commented Sep 22, 2020 •
edited

Fixes broadcast confirmation when connected to 1 bitcoin node

@oscarguindzberg oscarguindzberg changed the title Use bitcoinj 0.15.8 (commit a94ad23) [WIP] Use bitcoinj 0.15.8 (commit a94ad23) Sep 22, 2020
@oscarguindzberg
Copy link
Contributor Author

Moved to WIP. Waiting to see the progress of bitcoinj/bitcoinj#2054

@oscarguindzberg oscarguindzberg changed the title [WIP] Use bitcoinj 0.15.8 (commit a94ad23) [WIP] Use bitcoinj 0.15.8 (commit 5312aa3) Sep 24, 2020
@oscarguindzberg
Copy link
Contributor Author

oscarguindzberg commented Sep 24, 2020 •
edited

Pushed more code to bitcoinj:

  • Revert fix to broadcast confirmation when connected to 1 bitcoin node by enabling listener.
  • Add fix to broadcast confirmation when connected to 1 bitcoin node by setting the future immediately after tx broadcast.
  • Disable dropPeersAfterBroadcast feature because it is considered risky.

@oscarguindzberg oscarguindzberg changed the title [WIP] Use bitcoinj 0.15.8 (commit 5312aa3) Use bitcoinj 0.15.8 (commit 5312aa3) Sep 24, 2020
@oscarguindzberg
Copy link
Contributor Author

Removed WIP tag. This is ready to be merged in IMHO.

chimp1984
chimp1984 reviewed Sep 25, 2020
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

sqrrm
sqrrm previously approved these changes Sep 25, 2020
View reviewed changes
@sqrrm
Copy link
Member

sqrrm commented Sep 25, 2020

@oscarguindzberg commit not signed

@oscarguindzberg
Copy link
Contributor Author

@sqrrm sorry, I just signed the commit

@sqrrm sqrrm merged commit 1ea94a5 into bisq-network:master Sep 26, 2020
@oscarguindzberg oscarguindzberg mentioned this pull request Dec 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chimp1984 chimp1984 chimp1984 left review comments

@sqrrm sqrrm sqrrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oscarguindzberg @sqrrm @chimp1984