Change Venezuelan currency from VEF to VES #4572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingiun
force-pushed
the
change-vef-to-ves
branch
from
5a52122
to
fd8c629
Compare
|
|
pingiun
force-pushed
the
change-vef-to-ves
branch
from
fd8c629
to
fe71356
Compare
|
Aren't we upgrading Java soon? If so this patch likely isn't needed. |
|
I think @MwithM wanted to have this quite soon. If the Java version is upgraded in the next release, this should not be needed. Otherwise I think this is useful as a stop-gap |
|
@pingiun Thank you anyway for this doing this pull request so quickly. |
|
Closing as it will be superseded by #4242. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1920
This adds a properties file to supply to java.util.Currency so that it knows the Venezuelan currency is VES. Adding additional data to this class is quite cumbersome. You need to supply a properties file, but it cannot be a class resource, it has to live in an actual file. I placed this logic in BisqExecutable.java but I don't think it's the best location.
The currency currently has no display name, so the Bisq app defaults to "VES (VES)". I don't know how locale information within the Java jdk can be translated, so please help me with that. Alternatively I could do some checks in various places to check if the display name for VES is requested and we could use our own translation strings.
Update: I added translations from the bisq string resources
This code should be removed if we upgrade to Java 11 or newer, because the currency data is updated in those versions.