Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant DisputeAgentType enum #4595

Merged
merged 2 commits into from Oct 7, 2020
Merged

Remove redundant DisputeAgentType enum #4595

merged 2 commits into from Oct 7, 2020

Conversation

ghubstan
Copy link
Member

@ghubstan ghubstan commented Oct 3, 2020

Use existing SupportType enum instead, and map the valid CLI registerdisputeagent method's dispute-agent-type parameter names to SupportType.

Adjusted affected tests.

@ghubstan
Remove redundant DisputeAgentType enum
9942529 
Use existing SupportType enum instead, and map the valid api
'registerdisputeagent' method's dispute-agent-type parameter
names to SupportType.
@ghubstan ghubstan added this to In progress in Ship Bisq Daemon and API Oct 3, 2020
@ghubstan
Copy link
Member Author

ghubstan commented Oct 3, 2020

It was decided to ignore this PR's Switch statements should have a default label codacy complaint.

chimp1984
chimp1984 previously approved these changes Oct 4, 2020
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx
Copy link
Member

ripcurlx commented Oct 6, 2020

It was decided to ignore this PR's Switch statements should have a default label codacy complaint.

I removed the pattern.

ripcurlx
ripcurlx reviewed Oct 7, 2020
View reviewed changes
Copy link
Member

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK based on #4595 (review)

ripcurlx
ripcurlx approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK based on #4595 (review)

@ripcurlx ripcurlx merged commit 7d14ff3 into bisq-network:master Oct 7, 2020
Ship Bisq Daemon and API automation moved this from In progress to Done Oct 7, 2020
@ghubstan ghubstan mentioned this pull request Oct 7, 2020
Merged
@ghubstan ghubstan deleted the remove-duplicated-supporttype-enum branch October 7, 2020 14:24
@ghubstan ghubstan mentioned this pull request Oct 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

@chimp1984 chimp1984 chimp1984 left review comments

Assignees
No one assigned
Labels
None yet
Projects
Ship Bisq Daemon and API
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ghubstan @ripcurlx @chimp1984