Add new getoffer(id) api method #4598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Push the placeOffer call down into CoreOffersService#createOffer, and use a countdown latch to wait for async placeOffer to complete.
This is more readable and stylistically consistent.
There are a number of use cases where a user may want to see a single offer instead of every offer for a currency pair on the buy or sell side. The changes are: - Add getoffer to grpc.proto - Add new method to GrpcOffersService, CoreApi, CoreOffersService - Add new method to CLI - Adjust create offer tests to use this new convenience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of use cases where a CLI user may want to see a single offer instead of every offer for a currency pair on the buy or sell side. The changes are:
getoffertogrpc.protoGrpcOffersService,CoreApi,CoreOffersService