Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New trade statistics #4611

Merged
merged 59 commits into from Oct 9, 2020
Merged

New trade statistics #4611

Changes from 1 commit
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
9404e8f
Add NO_ADDRESS_PRE_FIX capability.
chimp1984 Oct 7, 2020
e73a4b4
Cleanups
chimp1984 Oct 7, 2020
6f7dfcf
Make onRemoved default in interface
chimp1984 Oct 7, 2020
40f9cfb
Add methods for getting peers capabilities
chimp1984 Oct 7, 2020
8aec306
Remove verification for address prefix
chimp1984 Oct 7, 2020
9821dd6
Clear capabilitiesListeners at shutdown
chimp1984 Oct 7, 2020
17974f3
Refactor: move SupportedCapabilitiesMessage handling code out to a me…
chimp1984 Oct 7, 2020
1c07be0
Use only node address for equals and hashcode
chimp1984 Oct 7, 2020
bf659a1
Pass supportedCapabilities to PeerManager. Not further processed yet,…
chimp1984 Oct 7, 2020
2523c2e
Use getSingleThreadListeningExecutor, cleanups
chimp1984 Oct 7, 2020
765f9ea
Apply code inspection suggestions
chimp1984 Oct 7, 2020
186a9d6
Add findPeersCapabilities method
chimp1984 Oct 7, 2020
7af16d7
Add getDateAsLong method, add setter for capabilities
chimp1984 Oct 7, 2020
25bfe2d
Add findPeersCapabilities method
chimp1984 Oct 7, 2020
2552675
Replace persistedPeers with peerList
chimp1984 Oct 7, 2020
bf674ea
Use getPersistedPeers for peerList.getList() calls
chimp1984 Oct 7, 2020
cf06930
Update common/src/main/java/bisq/common/app/Capability.java
chimp1984 Oct 7, 2020
983f610
Update p2p/src/main/java/bisq/network/p2p/network/Connection.java
chimp1984 Oct 7, 2020
31e7e26
Fix incorrect handling of decryptedEntries size
chimp1984 Oct 7, 2020
4575516
Refactor: Return early
chimp1984 Oct 7, 2020
ed960ab
Refactor: Rearrange code, remove unused methods, renamings (no functi…
chimp1984 Oct 7, 2020
0686079
Refactor: Rename method
chimp1984 Oct 7, 2020
31ce5cc
Use connection.getPeersNodeAddressOptional().isPresent() instead of c…
chimp1984 Oct 7, 2020
cfda0af
Fix tests
chimp1984 Oct 8, 2020
351db88
Use a hashset instead of list to avoid duplicates. Filter out my own …
chimp1984 Oct 8, 2020
2fd0104
Decrease failedConnectionAttempts onConnection
chimp1984 Oct 8, 2020
f36a173
Fix incorrect collection used in == 1 check
chimp1984 Oct 8, 2020
b748bff
Add isPresent check
chimp1984 Oct 8, 2020
c7f23e8
Do not log size as we don't want to call potentially expensive toProt…
chimp1984 Oct 8, 2020
f53290b
Copy peers in a new hashset to avoid concurrent modification exc at s…
chimp1984 Oct 8, 2020
447235c
Dont reassign param
chimp1984 Oct 8, 2020
c88bc1c
Use custom class MailboxItem instead of Tuple
chimp1984 Oct 8, 2020
c8feef1
Apply code review suggestions
chimp1984 Oct 8, 2020
4f685f8
When updating the capability from a reported peer we check if the rep…
chimp1984 Oct 8, 2020
6e3fdbc
Apply codacy suggestions
chimp1984 Oct 8, 2020
00bed02
Add TradeStatistics3 and related classes
chimp1984 Oct 5, 2020
406bcfb
Remove PublishTradeStatistics from buyer protocol
chimp1984 Oct 5, 2020
b75aa67
Refactor: Move class
chimp1984 Oct 5, 2020
a522d0a
Refactor: Rename class
chimp1984 Oct 5, 2020
b2665bd
let seller publish trade statistics only if peer is updated user. If …
chimp1984 Oct 5, 2020
6d43c09
Delete TradeStatistics (version 1)
chimp1984 Oct 5, 2020
9820751
We "hack" TradeStatistics2StorageService to fulfill our needs:
chimp1984 Oct 5, 2020
c4a4c87
Apply TradeStatistics3 to TradeStatisticsManager and some related cla…
chimp1984 Oct 5, 2020
52be126
Apply TradeStatistics3 to client classes
chimp1984 Oct 5, 2020
0e70a99
Adjust tests, remove tests which do not make sense anymore
chimp1984 Oct 5, 2020
6766835
Use TradeStatistics3 in protobuf file
chimp1984 Oct 5, 2020
b14266d
Remove resource file
chimp1984 Oct 5, 2020
9016cb6
Prune mediator and refund agent entries for all entries beside the la…
chimp1984 Oct 6, 2020
f56fe42
Add injector.getInstance(TradeStatisticsConverter.class) to BisqExecu…
chimp1984 Oct 6, 2020
fa374b9
Do conversion in a thread to not block UI thread. takes about 4 secon…
chimp1984 Oct 6, 2020
213050c
Add filter for excluding null objects
chimp1984 Oct 6, 2020
17f4ae2
Add check that size is > LOOK_BACK_RANGE
chimp1984 Oct 6, 2020
e95ab2a
Add resource file for 1.4.0 (should be updated at release time)
chimp1984 Oct 6, 2020
58d2f1b
Apply codacy suggestions
chimp1984 Oct 8, 2020
197d8c1
Remove copy&past mistake
chimp1984 Oct 8, 2020
18a27e9
Republish trade statistics from seller side if peer capability is kno…
chimp1984 Oct 8, 2020
68a10cf
Remove comment line
chimp1984 Oct 8, 2020
66740b7
Remove unused variable
chimp1984 Oct 9, 2020
39c8ade
Cleanups: Remove outdated TODOs, fix typos
chimp1984 Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 0 additions & 7 deletions desktop/src/test/java/bisq/desktop/main/market/trades/TradesChartsViewModelTest.java
View file
Open in desktop
Expand Up @@ -29,9 +29,6 @@
import bisq.core.trade.statistics.TradeStatisticsManager;
import bisq.core.user.Preferences;

import bisq.common.crypto.KeyRing;
import bisq.common.crypto.KeyStorage;

import org.bitcoinj.core.Coin;
import org.bitcoinj.utils.Fiat;

Expand All @@ -50,9 +47,6 @@
import java.util.HashSet;
import java.util.Set;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;
Expand Down Expand Up @@ -116,7 +110,6 @@ public void setup() throws IOException {
dir.delete();
//noinspection ResultOfMethodCallIgnored
dir.mkdir();
keyRing = new KeyRing(new KeyStorage(dir));
}

@SuppressWarnings("ConstantConditions")
Expand Down