Use a thread in PersistenceManager for reading persisted files instead of using threads in client code #4628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chimp1984
changed the title
chimp1984
changed the title
…d of using thread in client code Before we use a thread in readFromResources and readAllPersisted. To avoid that client code need to deal with threading we moved that to the PersistenceManager and changed the API accordingly so it will not return the persisted object but calls a consumer once it is completed with reading.
Add synchronous methods for tests. They new async methods lead to failing tests. It could be probably fixed, but its quite an effort... Don't like to add code just for tests but on the other hand, maybe those methods might be useful for other use cases as well.
chimp1984
force-pushed
the
improve-read-file-handling
branch
from
0cb1809
to
68583d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bases on 1.4.0 release branch but intended to get into master after release. Set it as draft to make more clear its not ready for merge yet (though ready for review). Code changes are at commit fa2163f.
Use a thread in PersistenceManager for reading persisted files instead of using threads in client code
Before we use a thread in readFromResources and readAllPersisted. To avoid that client code need to deal with
threading we moved that to the PersistenceManager and changed the API accordingly so it will not return the persisted object but calls a consumer once it is completed with reading.