Release/v1.4.0 and v1.4.1 #4655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Segwit is not used for BSQ
Use P2WPKH for AVAILABLE context and P2PKH for the rest. Disable reusing unused AVAILABLE entries until segwit support is mandatory in Bisq.
This is for backwards compatibility with bisq nodes that have not upgraded to bitcoinj 0.15.
For published delayed payout transactions we do not receive the tx confidence so we cannot check if it is confirmed so we ignore it for that check. The check is any arbitrarily using a limit of 20, so we don't need to be exact here. Should just reduce the likelihood of issues with the too long chains of unconfirmed transactions.
Persist seen mediator warnings
…t-check Dont include dead transactions in check for unconfirmed txs chain
Only remove offer locally when necessary
It doesn't work when running from the release binaries as JFoenix is relying on it right now.
ripcurlx
force-pushed
the
release/v1.4.0
branch
from
47044c5
to
bac1e7b
Compare
…t/response) We did check in Connection for SupportedCapabilitiesMessage and if a message is of that type we set the capability. But encrypted messages are wrapped in a PrefixedSealedAndSignedMessage so the payload is not visible as SupportedCapabilitiesMessage without decrypting it. We need to call maybeHandleSupportedCapabilitiesMessage at decrypting the message. We do that only for direct messages not for mailbox messages as we likely do not have a connection open to the peer in that case (otherwise it would not be a mailbox msg) and as we don't have the connection available (we get is as AddDataMessage broadcast from an peer, so could could not apply it to the Connection of the sender.
Remove republishing at SellerProtocol as we don't know the capability of the peer at that moment and as we also want to republish for completed trades.
…ng-for-encrypted-msg Handle Capabilities for encrypted messages (offer availibility request/response)
Fix republish trade stats
Move segwit checkbox
sqrrm
approved these changes
Oct 19, 2020
|
@ripcurlx There is an unsigned commit. I think we should allow it since it's deep in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.