New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/refresh displayString.properties #4671
Update/refresh displayString.properties #4671
Conversation
Thanks for opening this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvements—all small suggestions.
Thanks for the suggestions - will review and update :) |
Co-authored-by: m52go <mfiver@gmail.com>
Co-authored-by: m52go <mfiver@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now! Thanks @m52go
Waiting for ack from @m52go before merging |
ACK |
@Bayernatoor could you please force push to this branch again. It seems travis never run it as I didn't find it in the travis log. |
@ripcurlx Hey sorry for the delay. How do go about doing that? does it have to been locally on my own fork? Do I need to update my repo first? |
M52go walked me through it. I |
I have the feeling Travis flagged you or at least this PR. I'll cherry-pick the changes and try to create a PR myself. |
Superseded by #4750 |
See project for details. Related to PR4515
Corrected typos and grammatical errors. Improved some strings to help with clarity and guide users.