Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/refresh displayString.properties #4671

Closed

Conversation

Bayernatoor
Copy link
Member

See project for details. Related to PR4515

Corrected typos and grammatical errors. Improved some strings to help with clarity and guide users.

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 20, 2020

Thanks for opening this pull request!

Please check out our contributor checklist and check if Travis or Codacy found any issues with your PR. Also make sure your commits are signed, and that you applied Bisq's code style and formatting.

A maintainer will add an is:priority label to your PR if it is up for compensation. Please see our Bisq Q1 2020 Update post for more details.

Copy link
Contributor

@m52go m52go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements—all small suggestions.

core/src/main/resources/i18n/displayStrings.properties Outdated Show resolved Hide resolved
core/src/main/resources/i18n/displayStrings.properties Outdated Show resolved Hide resolved
core/src/main/resources/i18n/displayStrings.properties Outdated Show resolved Hide resolved
core/src/main/resources/i18n/displayStrings.properties Outdated Show resolved Hide resolved
@Bayernatoor
Copy link
Member Author

Thanks for the suggestions - will review and update :)

Co-authored-by: m52go <mfiver@gmail.com>
Co-authored-by: m52go <mfiver@gmail.com>
Copy link
Member Author

@Bayernatoor Bayernatoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now! Thanks @m52go

core/src/main/resources/i18n/displayStrings.properties Outdated Show resolved Hide resolved
core/src/main/resources/i18n/displayStrings.properties Outdated Show resolved Hide resolved
@Bayernatoor Bayernatoor marked this pull request as ready for review October 26, 2020 16:30
@sqrrm
Copy link
Member

sqrrm commented Oct 27, 2020

Waiting for ack from @m52go before merging

@m52go
Copy link
Contributor

m52go commented Oct 27, 2020

ACK

@ripcurlx
Copy link
Contributor

@Bayernatoor could you please force push to this branch again. It seems travis never run it as I didn't find it in the travis log.

@Bayernatoor
Copy link
Member Author

Bayernatoor commented Nov 3, 2020

@Bayernatoor could you please force push to this branch again. It seems travis never run it as I didn't find it in the travis log.

@ripcurlx Hey sorry for the delay. How do go about doing that? does it have to been locally on my own fork? Do I need to update my repo first?

@Bayernatoor
Copy link
Member Author

Bayernatoor commented Nov 3, 2020

M52go walked me through it.

I git pull origin correctdisplaystrings
and git push -f origin correctdisplaystrings

@ripcurlx
Copy link
Contributor

ripcurlx commented Nov 5, 2020

M52go walked me through it.

I git pull origin correctdisplaystrings
and git push -f origin correctdisplaystrings

I have the feeling Travis flagged you or at least this PR. I'll cherry-pick the changes and try to create a PR myself.

@ripcurlx ripcurlx mentioned this pull request Nov 5, 2020
@ripcurlx
Copy link
Contributor

ripcurlx commented Nov 5, 2020

Superseded by #4750

@ripcurlx ripcurlx closed this Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants