Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test api method 'canceloffer' #4716

Merged
merged 25 commits into from Nov 2, 2020
Merged

Commits on Oct 23, 2020

  1. Block on tx-fee-request in core TakeOfferModel init

    Added license comment too.
    ghubstan committed Oct 23, 2020
    Copy the full SHA
    cb65de6 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2020

  1. Copy the full SHA
    ab20225 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    63cf436 View commit details
    Browse the repository at this point in the history
  3. Replace static TradeUtil with singleton TradeUtil

    The API is going to need some desktop trade utilities, which should be
    shared between :desktop and :core.api.
    ghubstan committed Oct 24, 2020
    Copy the full SHA
    296e4f9 View commit details
    Browse the repository at this point in the history
  4. Fix comment typos

    ghubstan committed Oct 24, 2020
    Copy the full SHA
    ccd3c99 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2020

  1. Copy the full SHA
    24ba921 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    36ad137 View commit details
    Browse the repository at this point in the history
  3. Refactor PendingTradesDataModel methods -> TradeUtil

    Scope of this refactoring is small;  more can be done, but the short
    term goal is to share trade util logic with core api.
    
    - Removed unused method getCurrencyCode()
    - Made minor style changes
    - Removed duplicated code block
    ghubstan committed Oct 25, 2020
    Copy the full SHA
    95bcb1e View commit details
    Browse the repository at this point in the history
  4. Remove unused import

    ghubstan committed Oct 25, 2020
    Copy the full SHA
    bbd7a31 View commit details
    Browse the repository at this point in the history
  5. Add getRole(tradeId) to core api

    API users will need to see their role as maker/taker when looking at trade details.
    
    - Add getRole(trade) to TradeUtil.
    - Add getTradeRole(tradeId) to CoreApi, CoreTradesService.
    - Add role field to TradeInfo proto and its wrapper class.
    ghubstan committed Oct 25, 2020
    Copy the full SHA
    161dbad View commit details
    Browse the repository at this point in the history
  6. Refactor CLI output formatting code & add trade formatter

    - Move output column header specs to its own shared constants class.
    
    - Add new TradeFormat class for printing trade details in the console.
    
    - Print formatted trade in api trade tests -- to see output before
      using formatter in CLI (in next PR).
    ghubstan committed Oct 25, 2020
    Copy the full SHA
    3379376 View commit details
    Browse the repository at this point in the history
  7. Add license comment

    ghubstan committed Oct 25, 2020
    Copy the full SHA
    d8bc265 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    31435bb View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    2b23704 View commit details
    Browse the repository at this point in the history
  10. Add boolean 'showcontract' argument to api's 'gettrade'

    Optionally print the json contract for a given trade id.
    ghubstan committed Oct 25, 2020
    Copy the full SHA
    a2b2923 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. Stub out api methods 'keepfunds', 'withdrawfunds'

    This PR adds trade closing method stubs to keep funds in the
    Bisq wallet or send them to an external BTC wallet.
    
    - Add grpc protos
    - Add new methods to GrpcTradesService, CoreApi
    - Stub out implementations in CoreTradesService
    - Add methods to CLI
    ghubstan committed Oct 26, 2020
    Copy the full SHA
    a8decaf View commit details
    Browse the repository at this point in the history
  2. Implement api methods 'keepfunds', 'withdrawfunds'

    The CoreTradesService was refactored to work for newly added api methods:
    
    - keepfunds -- close trade, keep funds in bisq wallet
    
    - withdrawfunds -- close trade, withdraw funds to external btc wallet
    
    A getKey accessor was added to CoreWalletsService (needed by withdrawfunds impl).
    ghubstan committed Oct 26, 2020
    Copy the full SHA
    a3631a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. Copy the full SHA
    f1db254 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    b8ae566 View commit details
    Browse the repository at this point in the history
  3. Test trade closing api methods 'keepfunds' withdrawfunds'

    Some refactoring of the api test case hierarchy is included in this commit.
    ghubstan committed Oct 27, 2020
    Copy the full SHA
    1e25be5 View commit details
    Browse the repository at this point in the history
  4. Fix apitest dummy payment acct init bug

    This commit fixes non-trade tests broken by the last refactoring.
    ghubstan committed Oct 27, 2020
    Copy the full SHA
    2746b27 View commit details
    Browse the repository at this point in the history
  5. Stub out canceloffer api method

    The implementation will be added to CoreOffersService in the next PR.
    ghubstan committed Oct 27, 2020
    Copy the full SHA
    027a7d5 View commit details
    Browse the repository at this point in the history
  6. Fix typo

    ghubstan committed Oct 27, 2020
    Copy the full SHA
    0f1d4f8 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    b38507c View commit details
    Browse the repository at this point in the history
  8. Add canceloffer test

    ghubstan committed Oct 27, 2020
    Copy the full SHA
    91a2e2c View commit details
    Browse the repository at this point in the history