New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test api method 'canceloffer' #4716
Commits on Oct 23, 2020
-
Block on tx-fee-request in core TakeOfferModel init
Added license comment too.
Commits on Oct 24, 2020
-
-
-
Replace static TradeUtil with singleton TradeUtil
The API is going to need some desktop trade utilities, which should be shared between :desktop and :core.api.
-
Commits on Oct 25, 2020
-
-
Refactor PendingTradesDataModel methods -> TradeUtil
Scope of this refactoring is small; more can be done, but the short term goal is to share trade util logic with core api. - Removed unused method getCurrencyCode() - Made minor style changes - Removed duplicated code block
-
-
Add getRole(tradeId) to core api
API users will need to see their role as maker/taker when looking at trade details. - Add getRole(trade) to TradeUtil. - Add getTradeRole(tradeId) to CoreApi, CoreTradesService. - Add role field to TradeInfo proto and its wrapper class.
-
Refactor CLI output formatting code & add trade formatter
- Move output column header specs to its own shared constants class. - Add new TradeFormat class for printing trade details in the console. - Print formatted trade in api trade tests -- to see output before using formatter in CLI (in next PR).
-
-
-
-
Add boolean 'showcontract' argument to api's 'gettrade'
Optionally print the json contract for a given trade id.
Commits on Oct 26, 2020
-
Stub out api methods 'keepfunds', 'withdrawfunds'
This PR adds trade closing method stubs to keep funds in the Bisq wallet or send them to an external BTC wallet. - Add grpc protos - Add new methods to GrpcTradesService, CoreApi - Stub out implementations in CoreTradesService - Add methods to CLI
-
Implement api methods 'keepfunds', 'withdrawfunds'
The CoreTradesService was refactored to work for newly added api methods: - keepfunds -- close trade, keep funds in bisq wallet - withdrawfunds -- close trade, withdraw funds to external btc wallet A getKey accessor was added to CoreWalletsService (needed by withdrawfunds impl).
Commits on Oct 27, 2020
-
-
-
Test trade closing api methods 'keepfunds' withdrawfunds'
Some refactoring of the api test case hierarchy is included in this commit.
-
Fix apitest dummy payment acct init bug
This commit fixes non-trade tests broken by the last refactoring.
-
Stub out canceloffer api method
The implementation will be added to CoreOffersService in the next PR.
-
-