Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve issues found in reviewed PRs 4699, 4703, 4711 [, ...] #4731

Merged
merged 20 commits into from Nov 2, 2020
Merged

Resolve issues found in reviewed PRs 4699, 4703, 4711 [, ...] #4731

merged 20 commits into from Nov 2, 2020

Commits on Oct 26, 2020

  1. Implement api methods 'keepfunds', 'withdrawfunds' 

    The CoreTradesService was refactored to work for newly added api methods:

- keepfunds -- close trade, keep funds in bisq wallet

- withdrawfunds -- close trade, withdraw funds to external btc wallet

A getKey accessor was added to CoreWalletsService (needed by withdrawfunds impl).
    @ghubstan
    ghubstan committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    a3631a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. Make formatSatoshis visible for testing

    @ghubstan
    ghubstan committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    f1db254 View commit details
    Browse the repository at this point in the history

  2. Add method for printing current jupiter test name

    @ghubstan
    ghubstan committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    b8ae566 View commit details
    Browse the repository at this point in the history

  3. Test trade closing api methods 'keepfunds' withdrawfunds' 

    Some refactoring of the api test case hierarchy is included in this commit.
    @ghubstan
    ghubstan committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    1e25be5 View commit details
    Browse the repository at this point in the history

  4. Fix apitest dummy payment acct init bug 

    This commit fixes non-trade tests broken by the last refactoring.
    @ghubstan
    ghubstan committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    2746b27 View commit details
    Browse the repository at this point in the history

  5. Stub out canceloffer api method 

    The implementation will be added to CoreOffersService in the next PR.
    @ghubstan
    ghubstan committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    027a7d5 View commit details
    Browse the repository at this point in the history

  6. Fix typo

    @ghubstan
    ghubstan committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    0f1d4f8 View commit details
    Browse the repository at this point in the history

  7. Implement api method 'canceloffer'

    @ghubstan
    ghubstan committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    b38507c View commit details
    Browse the repository at this point in the history

  8. Add canceloffer test

    @ghubstan
    ghubstan committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    91a2e2c View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2020

  1. Upgrade jupiterVersion = '5.7.0' 

    This upgrades jupiter for all subprojects using this library, but
it does not affect released code.
    @ghubstan
    ghubstan committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    8e51e1e View commit details
    Browse the repository at this point in the history

  2. Improve apitest cmd line console logging 

    - Show full stack traces in console
- Do use previously cached test outputs
- Do not show skipped test name in console (too noisy)
- Show test run summary, including number of skipped tests
- Show note about skipped test info in the html report
- Show link to html report on test SUCCESS
    @ghubstan
    ghubstan committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    d6524bf View commit details
    Browse the repository at this point in the history

  3. Remove dead code

    @ghubstan
    ghubstan committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    2a05203 View commit details
    Browse the repository at this point in the history

  4. Refactor api test fixture setup 

    - Remove dead code from AbstractLinuxProcess.

- Make default dummy accts static in MethodTest.

- Simplify gRPC stub creation, btc block generation, dispute agent
  registration, and dummy acct initialization in test case startup.

- Make ExpectedProtocolStatus visible to scenario test pkg.
    @ghubstan
    ghubstan committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    f61f148 View commit details
    Browse the repository at this point in the history

  5. Remove redundant ScenarioTest superclass

    @ghubstan
    ghubstan committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    e8e55d2 View commit details
    Browse the repository at this point in the history

  6. Reduce apitest case execution time 

    Consolidated all method tests into fewer test cases by running them
from new 'scenario' test cases.  This cuts the current scaffold
setup & teardown times by almost 1/2.  No method tests were deleted
or duplicated.

(1)  Disabled all method (unit) test cases at the class level.
(2)  Added new scenario test cases to run all disabled test cases (1).

The method test cases can still be run by commenting out the @disabled
annotation.
    @ghubstan
    ghubstan committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    c2f8db3 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2020

  1. Add null checks in PendingTradesViewModel 

    These changes were requested in review of PR
bisq-network#4699
    @ghubstan
    ghubstan committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    0656c57 View commit details
    Browse the repository at this point in the history

  2. Simplify TradeUtil#getPaymentMethodNameWithCountryCode 

    These changes were requested in review of PR
bisq-network#4699
    @ghubstan
    ghubstan committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    f764e9f View commit details
    Browse the repository at this point in the history

  3. Fix grammar / typo 

    This change resolves issue found in PR review.  See
bisq-network#4703 (comment)
    @ghubstan
    ghubstan committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    3cd3bf0 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2020

  1. Use Bisq's timer in API's 'unlockwallet timeout(s)' 

    This change was requested in
chimp1984@961703e

This replaces and closes PR bisq-network#4558
    @ghubstan
    ghubstan committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    c27d5a6 View commit details
    Browse the repository at this point in the history

  2. Verify closedTradableManager.getTradableById return value is a Trade … 

    …instance

This change requested at bisq-network#4711 (comment)
    @ghubstan
    ghubstan committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    fcdfc68 View commit details
    Browse the repository at this point in the history