Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set initial value for bsqAverageTrimThreshold at update to 5% #4747

Merged
merged 2 commits into from Nov 5, 2020
Merged

Set initial value for bsqAverageTrimThreshold at update to 5% #4747

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9b3f9d
Set initial value for bsqAverageTrimThreshold to 5% in case of an
chimp1984 Nov 4, 2020
5817525
Check for 0 and only apply the value in that case.
chimp1984 Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion core/src/main/java/bisq/core/user/Preferences.java
View file
Open in desktop
Expand Up @@ -245,7 +245,16 @@ private void initFromPersistedPreferences(PreferencesPayload persisted) {
setCryptoCurrencies(prefPayload.getCryptoCurrencies());
setBsqBlockChainExplorer(prefPayload.getBsqBlockChainExplorer());
GlobalSettings.setDefaultTradeCurrency(preferredTradeCurrency);
prefPayload.setBsqAverageTrimThreshold(0.05);

// If a user has updated and the field was not set and get set to 0 by protobuf
// As there is no way to detect that a primitive value field was set we cannot apply
// a "marker" value like -1 to it. We also do not want to wrap the value in a new
// proto message as thats too much for that feature... So we accept that if the user
// sets the value to 0 it will be overwritten by the default at next startup.
if (prefPayload.getBsqAverageTrimThreshold() == 0) {
prefPayload.setBsqAverageTrimThreshold(0.05);
}

setupPreferences();
}

Expand Down