Renaming: Use transaction virtual size #4755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oscarguindzberg Have you checked the translation strings if there is any need for an update as well? |
|
@chimp1984 I just fixed displayStrings.properties. |
Yes translater do the other languages. No need to waste your valuable dev time on translations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #4710
Since segwit was implemented we use "bitcoin transaction virtual size" instead of "bitcoin transaction size" in the code.
I did not want to do all the renaming of methods and variable names in #4710 to reduce merging hell.
So, I am doing it now.
Don't get overwhelmed by the number of changes... this is just a renaming PR.
Please, merge #4754 before merging this PR.