Update release process to match new trade statistics delivery #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripcurlx
force-pushed
the
update-release-process
branch
from
10948d7
to
a956307
Compare
ghubstan
suggested changes
Nov 10, 2020
There was a problem hiding this comment.
It's not due to this commit, but a link in release-process.md is broken.
Under Build release ->
Make sure all version numbers are updated (update version variables and run replace_version_number.sh)., the link to replace_version_number.sh is broken.
ghubstan
suggested changes
Nov 10, 2020
There was a problem hiding this comment.
Under Sign release on macOS, the link to finalize.sh is also broken.
Also did some minor release process cleanup that was overdue
ripcurlx
force-pushed
the
update-release-process
branch
from
a956307
to
7701ad3
Compare
sqrrm
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also did some minor release process cleanup that was overdue