Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stub out new api method 'getunusedbsqaddress' #4772

Closed
wants to merge 1 commit into from
Closed

Stub out new api method 'getunusedbsqaddress' #4772

wants to merge 1 commit into from

Conversation

ghubstan
Copy link
Member

@ghubstan ghubstan commented Nov 9, 2020

This api method will return one unused BSQ address. It will take no arguments, and return a String.

@ghubstan
Stub out new api method 'getunusedbsqaddress'
6b5f169 
This api method will return one unused BSQ address.  It will take
no arguments, and return a String.
@ghubstan ghubstan added this to In progress in Ship Bisq Daemon and API Nov 9, 2020
This was referenced Nov 9, 2020
Closed
Closed
@ghubstan
Copy link
Member Author

ghubstan commented Nov 9, 2020

The codacy complaint about unused field private final BsqWalletService bsqWalletService is fixed in PR #4773, where the method stubbed out here is implemented, and field is used. Hopefully this codacy complaint will not block merge.

@ghubstan
Copy link
Member Author

Will be included in later PR.

@ghubstan ghubstan closed this Nov 10, 2020
Ship Bisq Daemon and API automation moved this from In progress to Done Nov 10, 2020
@ghubstan ghubstan removed this from Done in Ship Bisq Daemon and API Nov 13, 2020
@ghubstan ghubstan deleted the stubout-getbsqfundingaddress branch November 24, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ghubstan