Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve offer publishing #4950

Merged
merged 7 commits into from Dec 29, 2020
Merged

Improve offer publishing #4950

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b553130
Cleanup
chimp1984 Dec 15, 2020
7bfbd0f
Change handling of delay at republishing
chimp1984 Dec 15, 2020
8e71575
Add else case for check for offer is in source list and deActivate state
chimp1984 Dec 16, 2020
24f53e0
Add flush method.
chimp1984 Dec 16, 2020
1049b7d
Remove delay for publishing
chimp1984 Dec 16, 2020
83e620d
Fix missing param in test
chimp1984 Dec 16, 2020
c5d0fa7
Move stopPeriodicRefreshOffersTimer before processListForRepublishOffers
chimp1984 Dec 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions core/src/main/java/bisq/core/offer/OpenOfferManager.java
View file
Open in desktop
Expand Up @@ -893,9 +893,14 @@ private void processListForRepublishOffers(List<OpenOffer> list) {

OpenOffer openOffer = list.remove(0);
if (openOffers.contains(openOffer) && !openOffer.isDeactivated()) {
republishOffer(openOffer,
// TODO It is not clear yet if it is better for the node and the network to send out all add offer
// messages in one go or to spread it over a delay. With power users who have 100-200 offers that can have
// some significant impact to user experience and the network
republishOffer(openOffer, () -> processListForRepublishOffers(list));

/* republishOffer(openOffer,
() -> UserThread.runAfter(() -> processListForRepublishOffers(list),
30, TimeUnit.MILLISECONDS));
30, TimeUnit.MILLISECONDS));*/
} else {
// If the offer was removed in the meantime or if its deactivated we skip and call
// processListForRepublishOffers again with the list where we removed the offer already.
Expand Down