Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix required opt validation bugs in CLI #5274

Closed
wants to merge 28 commits into from
Closed

Fix required opt validation bugs in CLI #5274

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
d60c0dd
Display buyer's cost in api's gettrade output
ghubstan Feb 26, 2021
e2bb64d
Merge branch 'master' into 01-show-cost-in-trade-output
ghubstan Feb 27, 2021
e5291e9
Use the logger of the gRPC service throwing an exception
ghubstan Feb 27, 2021
e5a0a39
Permit some gRPC excptions to be logged only as warning
ghubstan Feb 27, 2021
320e63c
Log 'trade not found' a warning instead of full stack trace
ghubstan Feb 27, 2021
98ff6cf
Fix test bug
ghubstan Feb 27, 2021
e8d1f03
Clean up call rate meter config file in test teardown
ghubstan Feb 27, 2021
f90d2ce
Fix test bug
ghubstan Feb 27, 2021
6b2c386
Fix call rate metering interceptor bug
ghubstan Feb 28, 2021
675ce98
Make test call rate = default call rate
ghubstan Feb 28, 2021
7249509
No need to wait, default+test call rate > 2x / second
ghubstan Feb 28, 2021
3feacf4
Remove unused import
ghubstan Feb 28, 2021
3bbefff
Adjust mainnet bats test to default rate meter interceptors
ghubstan Feb 28, 2021
b618776
Wait 3 secs after removing password (for wallet save)
ghubstan Feb 28, 2021
19aed84
Fix getunusedbsqaddress test
ghubstan Feb 28, 2021
3f84246
Improve interceptor's rate metering key definition and lookup
ghubstan Feb 28, 2021
392c0f5
Fix CLI number opt validation, improve server-not-up msg
ghubstan Mar 1, 2021
2473ff6
Fix tx-fee-rate formatting (and math) bug in cli/CurrencyFormat
ghubstan Mar 2, 2021
8590c67
Remove warning supression
ghubstan Mar 2, 2021
e0bf773
Add link to api-beta-test-guide.md
ghubstan Mar 3, 2021
a2000bd
Explain how to manually register test dispute agents
ghubstan Mar 3, 2021
cfaa539
Fix opt validation bugs in CLI
ghubstan Mar 4, 2021
62ff79d
Update cli getoffers smoke test to posix style opts
ghubstan Mar 5, 2021
d01a7b7
Improve required-argument opt validation
ghubstan Mar 5, 2021
304781c
Add jupiter test support to :cli subproject
ghubstan Mar 5, 2021
9c12b31
Add new cli option parser test
ghubstan Mar 5, 2021
a13ef79
Handle require-arg options missing the = sign
ghubstan Mar 5, 2021
70da6d1
Parse args in opts test, no exception = pass
ghubstan Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions cli/src/test/java/bisq/cli/opt/OptionParsersTest.java
View file
Open in desktop
Expand Up @@ -130,6 +130,7 @@ public void testValidCreateOfferOpts() {
"--" + OPT_MKT_PRICE_MARGIN + "=" + "0.0",
"--" + OPT_SECURITY_DEPOSIT + "=" + "25.0"
};
ghubstan marked this conversation as resolved.
Show resolved Hide resolved
new CreateOfferOptionParser(args).parse();
}

// CreatePaymentAcct opt parser tests
Expand Down