Update testing steps. #5317
Update testing steps. #5317
Conversation
Instructions for setting up a self-contained local Bisq network on Bitcoin regtest have been updated. `dev-setup.md` is deprecated. `Makefile` is new new version. Reference: https://github.com/bisq-network/bisq/blob/master/docs/README.md
There was a problem hiding this comment.
NACK - path is wrong. There is not Makefile.md and I wouldn't say dev-setup.md is deprecated. There are more details in the dev-setup.md that are useful if the the default setup in the makefile is not enough for testing. I think best would be to reference both in the testing documentation.
Use both links for setting up. Make it clear one is more recent than the other.
Makefile link is wrong as pointed out in the comments. Its correct location is one level higher than the wrong link.
|
Fixed. |
docs/testing.md
Outdated
| @@ -1,13 +1,14 @@ | |||
| # Bisq Testing Guide | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Could you please remove this empty line. Sometimes Travis gets stuck - in that case just leave a comment and I'll trigger a manual rebuild.
There was a problem hiding this comment.
Done. Please rebuild.
There was a problem hiding this comment.
continuous-integration/travis-ci/pr — The Travis CI build failed
There was a problem hiding this comment.
Just re-triggered a Travis build
wallclockbuilder
force-pushed
the
patch-2
branch
from
fc895be
to
ae6bfee
Compare
Co-authored-by: Christoph Atteneder <christoph.atteneder@gmail.com>
Instructions for setting up a self-contained local Bisq network on Bitcoin regtest have been updated.
dev-setup.mdis deprecated.Makefileis new new version.Reference: https://github.com/bisq-network/bisq/blob/master/docs/README.md