Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add front matter to issue_template.md #5352

Merged

Conversation

huey735
Copy link
Member

@huey735 huey735 commented Mar 24, 2021

I added semanticly relevant front matter to the issue_template.md
so that it explicit that it should be reserved for reporting bugs
or unintentional behaviours from the software.

@huey735
Copy link
Member Author

huey735 commented Mar 24, 2021

#5346 broke the Github issues @sqrrm. I think I also need to rename issue_template.md to bug_report.md. Should I do it here or create a new PR?

@ripcurlx
Copy link
Member

I just have ignored the file from Codacy. Could you please force push to re-trigger the Codacy check? Thanks!

@huey735 huey735 force-pushed the add-front-matter-to-bug-report-template branch from 6a2de4c to f56a406 Compare March 24, 2021 12:14
@huey735
Copy link
Member Author

huey735 commented Mar 24, 2021

Done.

ripcurlx
ripcurlx previously approved these changes Mar 24, 2021
Copy link
Member

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx
Copy link
Member

You missed to sign the commit

ripcurlx
ripcurlx previously approved these changes Mar 24, 2021
Copy link
Member

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx
Copy link
Member

5322629 is not signed yet

@huey735
Copy link
Member Author

huey735 commented Mar 24, 2021

Oh. How can I fix that?

@ripcurlx
Copy link
Member

I've just ignored the other file as well in codacy. Could you please force push again? Thanks!

@huey735 huey735 force-pushed the add-front-matter-to-bug-report-template branch from 1418631 to 204ab0a Compare March 24, 2021 21:11
Renamed the issue_template.md to bug-report.md to adhere to
Github's guidelines.
I added semanticly relevant front matter to the issue_template.md
so that it explicit that it should be reserved for reporting bugs
or unintentional behaviours from the software.
@huey735 huey735 force-pushed the add-front-matter-to-bug-report-template branch from 204ab0a to 040fc00 Compare March 24, 2021 21:12
Copy link
Member

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 00616ac into bisq-network:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants