Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/build.yml: new GitHub Action #5404

Merged
merged 1 commit into from May 4, 2021

Conversation

maxim-belkin
Copy link
Contributor

A GitHub action that builds Bisq on Ubuntu 18.04.

@ripcurlx
Copy link
Contributor

A GitHub action that builds Bisq on Ubuntu 18.04.

Is there an additional benefit doing it like that compared to what we have configured for Travis right now?

@maxim-belkin
Copy link
Contributor Author

Is there an additional benefit doing it like that compared to what we have configured for Travis right now?

  • Travis has a limit of 10,000 credits that doesn't reset/renew (link), so the switch is (more or less) imminent.
  • The submitted action has no advantages over what Travis CI is currently set up to do. The benefits of using GH Actions become more obvious when the CI/CD system is a bit more complex.

I can tweak the action to make it a bit more useful (test scripts in the /scripts directory, test different OSes,...) -- just let me know what you'd like to automate.

@ripcurlx
Copy link
Contributor

Right now we support Java 10 (for releases) and Java 12 (development). That is why we added both versions. As soon as #4242 gets merged Java 11 will be the sole support version. Does master build for you with Java 11 right now if you run the action on your forked repo?

Regarding the move from travis-ci.org to travis-ci.com: Yes there might be a problem if they don't allow unlimited jobs for OS projects. I think the only thing that is missing on this action is the Asset check that is in place right now

bisq/.travis.yml

Lines 15 to 16 in 64fe6c1

before_install:
grep -v '^#' assets/src/main/resources/META-INF/services/bisq.asset.Asset | sort --check --dictionary-order --ignore-case

@ripcurlx
Copy link
Contributor

ripcurlx commented May 4, 2021

As this use of GitHub actions doesn't introduce any risks I'll merge it as it might be a good alternative if we have to move away from Travis soon.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 177067e into bisq-network:master May 4, 2021
@maxim-belkin
Copy link
Contributor Author

Thanks for merging, @ripcurlx!

@maxim-belkin maxim-belkin deleted the gh-action branch May 4, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants