Size popup proportional to amount of text shown #5424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
cashbymail_enhance_terms2
branch
from
c10fb54
to
ca98975
Compare
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #5399 which cleans up a minor display issue.
CashByMail terms are defined by the offer maker, some users have only 1 line of text, others have a lengthy contract.
For the cases where only 1 line is shown, the large popup taking the whole screen looks a bit ridiculous, so here we vertically size the popup proportional to the number of lines in the message (with limits to not be < 20% or > 70% of allowable height).
Here are some example screenshots comparing the results with lots of text, and just one line.