Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pricenode: Increase mempool fee suggestion from medium to high priority #5426

Conversation

wiz
Copy link
Member

@wiz wiz commented Apr 21, 2021

Due to the recent high mining variance and mempool congestion, some users are reporting stuck trades due to TX getting stuck in the mempool. To help, this PR increases pricenodes usage of mempool.space fee suggestions from medium to high priority.

@Emzy
Copy link
Contributor

Emzy commented Apr 21, 2021

I agree. And running it on my pricenode.

@ripcurlx ripcurlx added this to the v1.6.3 milestone Apr 22, 2021
Copy link
Member

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 0852bce into bisq-network:master Apr 22, 2021
@Conza88
Copy link

Conza88 commented Apr 23, 2021

So it's just a suggestion?
Would be cool if UX wise, user could get an indication from mempool and choose the 'medium' or 'high' or 'low' suggestion.

@pazza83
Copy link

pazza83 commented Apr 24, 2021

I think this includes the transactions for the trade protocol. Hopefully will reduce the cases of trades being stuck for a few days or longer before confirming.

In these cases I think users should not be able to choose the fee as it could have a detrimental impact on their counterparty (long wait for trade confirmations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants