Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cli test that blocks building on Windows #5436

Merged
merged 1 commit into from Apr 23, 2021

Conversation

BtcContributor
Copy link
Contributor

This fix a path issue that was blocking users to build Bisq on Windows from terminal when using a command like gradlew.bat build

Fix tested on Windows and Linux/macOS.

The error was:

Task :cli:test FAILED

bisq.cli.opt.OptionParsersTest > testCreatePaymentAcctOptParserWithInvalidPaymentFormOptValueShouldThrowException() FAILED
    org.opentest4j.AssertionFailedError at OptionParsersTest.java:179

Due to:

testCreatePaymentAcctOptParserWithInvalidPaymentFormOptValueShouldThrowException()

org.opentest4j.AssertionFailedError: expected: <json payment account form '/tmp/milkyway/solarsystem/mars' could not be found> but was: <json payment account form '\tmp\milkyway\solarsystem\mars' could not be found>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1124)
	at bisq.cli.opt.OptionParsersTest.testCreatePaymentAcctOptParserWithInvalidPaymentFormOptValueShouldThrowException(OptionParsersTest.java:179)

Copy link
Member

@ghubstan ghubstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Member

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK based on #5436 (review)

@ripcurlx ripcurlx merged commit 33d0f11 into bisq-network:master Apr 23, 2021
@BtcContributor BtcContributor deleted the fixclitest branch April 26, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants