Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api beta test guide: add 'editoffer' #5577

Merged
merged 47 commits into from Aug 30, 2021

Commits on Jun 12, 2021

  1. Refactor EditOfferDataModel for new editoffer api method

    - Define set of editable offer payload fields in MutableOfferPayloadFields.
    
    - Move bulk of EditOfferDataModel#onPublishOffer logic to OfferUtil.
    ghubstan committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    81da6fb View commit details
    Browse the repository at this point in the history
  2. Fix comment

    ghubstan committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    d9dd718 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2021

  1. Configuration menu
    Copy the full SHA
    1daf471 View commit details
    Browse the repository at this point in the history
  2. Add server/core editOffer, adjust getMyOffer(s) impls

    - Add editOffer to GrpcOffersService, CoreApi, CoreOffersService.
    
    - Set editOffer call rate meter to 1 / minute.
    
    - Use new EditOfferValidator to verify editOffer params OK.
    
    - Adust getMyOffer(s) rpc impl and OfferInfo model to use OpenOffer
      for accessing activation state and trigger price.
    ghubstan committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    2b8b53b View commit details
    Browse the repository at this point in the history
  3. Refactor GrpcClient: request builders moved bisq.cli.request pkg

    Reduces size of GrpcClient while allowing for additional bot-friendly
    variations of the new grpc editOffer method.
    ghubstan committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    9231e48 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d2939cc View commit details
    Browse the repository at this point in the history
  5. Add editoffer method help

    ghubstan committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    2344285 View commit details
    Browse the repository at this point in the history
  6. Add editoffer to CLI

    ghubstan committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    be249c5 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    929b28c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    571568a View commit details
    Browse the repository at this point in the history
  9. Remove unused import

    ghubstan committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    9a5e2d0 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    05f3985 View commit details
    Browse the repository at this point in the history
  11. Fix codacy issue

    ghubstan committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    54efad0 View commit details
    Browse the repository at this point in the history
  12. Fix log arg spec bug

    ghubstan committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    21ac46a View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. Configuration menu
    Copy the full SHA
    32688a7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    738d2f7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e2a205a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4da64b9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    063b52e View commit details
    Browse the repository at this point in the history
  6. Remove unused field

    ghubstan committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    e5b5a06 View commit details
    Browse the repository at this point in the history
  7. Throw exception is edit altcoin offer is attempted

    Support for editing BSQ offers is in place, but will be added
    in another PR.
    ghubstan committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    bc1576e View commit details
    Browse the repository at this point in the history
  8. Avoid duplicate test run

    ghubstan committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    a3ea4ec View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3d38a85 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. Configuration menu
    Copy the full SHA
    1a56a51 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. Include isMyOffer flag in API's trade/offer proto wrappers

    Optionally displaying an ENABLED column in CLI side getoffer output
    depends on the value of offer.isMyOffer, which is passed via new
    boolean arguments to the trade & offer pojo builders.
    ghubstan committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    0e9c665 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a603044 View commit details
    Browse the repository at this point in the history
  3. Add altcoin (bsq) offer editing validation check

    BSQ offers are fixed-price only.  This change blocks an
    attempt to change an altcoin offer to a margin price based
    offer, or set a trigger price.
    ghubstan committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    e32e0d1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b74f084 View commit details
    Browse the repository at this point in the history
  5. Add BSQ offer editing tests to EditOfferTest

    And log CLI's getoffer output to see getoffer formatting -- after adding
    new ENABLED and TRIGGER-PRICE columns.
    ghubstan committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    7880a84 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2021

  1. Configuration menu
    Copy the full SHA
    ab2edac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0a3e011 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8115866 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    acbf1e4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9703b87 View commit details
    Browse the repository at this point in the history
  6. Fix header

    ghubstan committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    05f4f4d View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2021

  1. Delete tmp main() method

    ghubstan committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    06efcdf View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2021

  1. Rename and move private function

    And make sure function is not duplicated CLI side logic.
    ghubstan committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    eb62f93 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1992bcb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    622f7e9 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Configuration menu
    Copy the full SHA
    a4278a4 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2021

  1. Always use Locale.US in CLI DecimalFormats

    Avoid inconsistent CLI output decimal formats across different
    systems' default locales.
    ghubstan committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    649c98a View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2021

  1. Configuration menu
    Copy the full SHA
    b8379e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b4ee6db View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    95bbb41 View commit details
    Browse the repository at this point in the history
  4. Fix peer add(offer) & remove(offer) event order problem

    Use LinkedHashSet to maintain NetworkEnvelope ordering when Connection#onBundleOfEnvelopes
    calls listeners.
    
    Connection#onBundleOfEnvelopes builds a set from an ordered list of NetworkEnvelopes,
    then calls listeners during set iteration.  The envelope list ordering is lost if a
    HashSet is built, but maintained by switching to a LinkedHashSet.
    
    Losing the envelope ordering becomes a problem if the peer receives a RemoveDataMessage
    and an AddDataMessage in the same batch of envelopes, and relays them to listeners
    in the wrong (random) order.  For example, an API 'editoffer' call may result in the
    edited offer being added, then immediately remove from their UI's offer book.
    ghubstan committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    add6536 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2021

  1. Configuration menu
    Copy the full SHA
    094bc52 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2021

  1. Configuration menu
    Copy the full SHA
    3693728 View commit details
    Browse the repository at this point in the history