New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update api beta test guide: add 'editoffer' #5577
Update api beta test guide: add 'editoffer' #5577
Commits on Jun 12, 2021
-
Refactor EditOfferDataModel for new editoffer api method
- Define set of editable offer payload fields in MutableOfferPayloadFields. - Move bulk of EditOfferDataModel#onPublishOffer logic to OfferUtil.
Configuration menu - View commit details
-
Copy full SHA for 81da6fb - Browse repository at this point
Copy the full SHA 81da6fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9dd718 - Browse repository at this point
Copy the full SHA d9dd718View commit details
Commits on Jun 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1daf471 - Browse repository at this point
Copy the full SHA 1daf471View commit details -
Add server/core editOffer, adjust getMyOffer(s) impls
- Add editOffer to GrpcOffersService, CoreApi, CoreOffersService. - Set editOffer call rate meter to 1 / minute. - Use new EditOfferValidator to verify editOffer params OK. - Adust getMyOffer(s) rpc impl and OfferInfo model to use OpenOffer for accessing activation state and trigger price.
Configuration menu - View commit details
-
Copy full SHA for 2b8b53b - Browse repository at this point
Copy the full SHA 2b8b53bView commit details -
Refactor GrpcClient: request builders moved bisq.cli.request pkg
Reduces size of GrpcClient while allowing for additional bot-friendly variations of the new grpc editOffer method.
Configuration menu - View commit details
-
Copy full SHA for 9231e48 - Browse repository at this point
Copy the full SHA 9231e48View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2939cc - Browse repository at this point
Copy the full SHA d2939ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2344285 - Browse repository at this point
Copy the full SHA 2344285View commit details -
Configuration menu - View commit details
-
Copy full SHA for be249c5 - Browse repository at this point
Copy the full SHA be249c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 929b28c - Browse repository at this point
Copy the full SHA 929b28cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 571568a - Browse repository at this point
Copy the full SHA 571568aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a5e2d0 - Browse repository at this point
Copy the full SHA 9a5e2d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05f3985 - Browse repository at this point
Copy the full SHA 05f3985View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54efad0 - Browse repository at this point
Copy the full SHA 54efad0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21ac46a - Browse repository at this point
Copy the full SHA 21ac46aView commit details
Commits on Jun 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 32688a7 - Browse repository at this point
Copy the full SHA 32688a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 738d2f7 - Browse repository at this point
Copy the full SHA 738d2f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2a205a - Browse repository at this point
Copy the full SHA e2a205aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4da64b9 - Browse repository at this point
Copy the full SHA 4da64b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 063b52e - Browse repository at this point
Copy the full SHA 063b52eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5b5a06 - Browse repository at this point
Copy the full SHA e5b5a06View commit details -
Throw exception is edit altcoin offer is attempted
Support for editing BSQ offers is in place, but will be added in another PR.
Configuration menu - View commit details
-
Copy full SHA for bc1576e - Browse repository at this point
Copy the full SHA bc1576eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a3ea4ec - Browse repository at this point
Copy the full SHA a3ea4ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d38a85 - Browse repository at this point
Copy the full SHA 3d38a85View commit details
Commits on Jun 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1a56a51 - Browse repository at this point
Copy the full SHA 1a56a51View commit details
Commits on Jun 18, 2021
-
Include isMyOffer flag in API's trade/offer proto wrappers
Optionally displaying an ENABLED column in CLI side getoffer output depends on the value of offer.isMyOffer, which is passed via new boolean arguments to the trade & offer pojo builders.
Configuration menu - View commit details
-
Copy full SHA for 0e9c665 - Browse repository at this point
Copy the full SHA 0e9c665View commit details -
Configuration menu - View commit details
-
Copy full SHA for a603044 - Browse repository at this point
Copy the full SHA a603044View commit details -
Add altcoin (bsq) offer editing validation check
BSQ offers are fixed-price only. This change blocks an attempt to change an altcoin offer to a margin price based offer, or set a trigger price.
Configuration menu - View commit details
-
Copy full SHA for e32e0d1 - Browse repository at this point
Copy the full SHA e32e0d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b74f084 - Browse repository at this point
Copy the full SHA b74f084View commit details -
Add BSQ offer editing tests to EditOfferTest
And log CLI's getoffer output to see getoffer formatting -- after adding new ENABLED and TRIGGER-PRICE columns.
Configuration menu - View commit details
-
Copy full SHA for 7880a84 - Browse repository at this point
Copy the full SHA 7880a84View commit details
Commits on Jun 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ab2edac - Browse repository at this point
Copy the full SHA ab2edacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a3e011 - Browse repository at this point
Copy the full SHA 0a3e011View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8115866 - Browse repository at this point
Copy the full SHA 8115866View commit details -
Configuration menu - View commit details
-
Copy full SHA for acbf1e4 - Browse repository at this point
Copy the full SHA acbf1e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9703b87 - Browse repository at this point
Copy the full SHA 9703b87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05f4f4d - Browse repository at this point
Copy the full SHA 05f4f4dView commit details
Commits on Jul 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 06efcdf - Browse repository at this point
Copy the full SHA 06efcdfView commit details
Commits on Jul 12, 2021
-
Rename and move private function
And make sure function is not duplicated CLI side logic.
Configuration menu - View commit details
-
Copy full SHA for eb62f93 - Browse repository at this point
Copy the full SHA eb62f93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1992bcb - Browse repository at this point
Copy the full SHA 1992bcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 622f7e9 - Browse repository at this point
Copy the full SHA 622f7e9View commit details
Commits on Jul 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a4278a4 - Browse repository at this point
Copy the full SHA a4278a4View commit details
Commits on Jul 15, 2021
-
Always use Locale.US in CLI DecimalFormats
Avoid inconsistent CLI output decimal formats across different systems' default locales.
Configuration menu - View commit details
-
Copy full SHA for 649c98a - Browse repository at this point
Copy the full SHA 649c98aView commit details
Commits on Jul 30, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b8379e2 - Browse repository at this point
Copy the full SHA b8379e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4ee6db - Browse repository at this point
Copy the full SHA b4ee6dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 95bbb41 - Browse repository at this point
Copy the full SHA 95bbb41View commit details -
Fix peer add(offer) & remove(offer) event order problem
Use LinkedHashSet to maintain NetworkEnvelope ordering when Connection#onBundleOfEnvelopes calls listeners. Connection#onBundleOfEnvelopes builds a set from an ordered list of NetworkEnvelopes, then calls listeners during set iteration. The envelope list ordering is lost if a HashSet is built, but maintained by switching to a LinkedHashSet. Losing the envelope ordering becomes a problem if the peer receives a RemoveDataMessage and an AddDataMessage in the same batch of envelopes, and relays them to listeners in the wrong (random) order. For example, an API 'editoffer' call may result in the edited offer being added, then immediately remove from their UI's offer book.
Configuration menu - View commit details
-
Copy full SHA for add6536 - Browse repository at this point
Copy the full SHA add6536View commit details
Commits on Aug 2, 2021
-
Revert "Fix peer add(offer) & remove(offer) event order problem"
This reverts commit add6536.
Configuration menu - View commit details
-
Copy full SHA for 094bc52 - Browse repository at this point
Copy the full SHA 094bc52View commit details
Commits on Aug 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3693728 - Browse repository at this point
Copy the full SHA 3693728View commit details