Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Atomic bsq trades #5729

Closed
wants to merge 160 commits into from
Closed

Commits on Sep 27, 2021

  1. Refactor direct offerPayload access

    Broaden type requirement
    sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    4a99d79 View commit details
    Browse the repository at this point in the history
  2. Refactor direct offerPayload access

    Let Offer handle all OfferPayload data access.
    sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    170bc8a View commit details
    Browse the repository at this point in the history
  3. Add OfferPayloadI

    An interface for OfferPayload currently only used by OfferPayload. Some
    features won't be available for newer payload types but to fit this into
    the Offer and Trade framework it's necessary to hack it a bit.
    sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    c46906f View commit details
    Browse the repository at this point in the history
  4. Add AtomicOfferPayload

    Offer protobuf has oneof FeeTxOfferPayload and AtomicOfferPayload. This is
    backwards compatible since the wire format is the same for the old Offer
    and the new one with offer_payload set since the index is the same.
    sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    d78ed1b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    100c13c View commit details
    Browse the repository at this point in the history
  6. Add atomic account type

    Add a hidden account type that's automatically used for BSQ trades. This
    means old orders not using AtomicAccount can still complete the trades
    as per normal and new offers placed with AtomicAccount can be taken by
    anyone with an upgraded client, but won't be possible to take by users
    with older clients.
    
    The atomic account is added on startup if not already added. There is no
    data associated with the account, a new BSQ address will be chosen
    automatically during the atomic trade process.
    sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    3762962 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ff0c6c6 View commit details
    Browse the repository at this point in the history
  8. Add UI for taking atomic offers

    Copy paste of normal take offer code with extra steps removed
    
    Added AtomicTxBuilder prototype as a way to build the atomic tx, verify
    inputs and gather input requirements. Only the input requirement is used
    during the take offer process.
    sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    7672576 View commit details
    Browse the repository at this point in the history
  9. Refactor: TradeManager handle Tradable

    This prepares for letting TradeManager handle AtomicTrade that is a Tradable
    sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    ea5bf55 View commit details
    Browse the repository at this point in the history
  10. Refactor: add class tradeModel

    sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    72eb38d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c108841 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    06352d9 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    74aee8d View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    7dc50d2 View commit details
    Browse the repository at this point in the history
  15. Add AtomicApplyFilter

    sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    34e8f1d View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    a0e79c0 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    e57763a View commit details
    Browse the repository at this point in the history
  18. Take atomic offer

    sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    7ac28dd View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    aa22b54 View commit details
    Browse the repository at this point in the history
  20. Add atomic trade protocol

    Add atomic trade tab under portfolio
    sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    9a1d1df View commit details
    Browse the repository at this point in the history
  21. Set maker fee type in offer

    sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    ee18eb9 View commit details
    Browse the repository at this point in the history
  22. Display Atomic Trade info in transaction lists

    Set txid when parsing AtomicTrade from protobuf
    sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    5da71fb View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    7e7327a View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    924236a View commit details
    Browse the repository at this point in the history
  25. Add ProofOfWorkPayload filter

    sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    644aee8 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    823cc64 View commit details
    Browse the repository at this point in the history
  27. Add atomic offer/trade grpc proto defs

    - Add offers service protos: GetAtomicOffer, GetMyAtomicOffer,
      GetAtomicOffers, GetMyAtomicOffers, CreateAtomicOffer.
    
    - Add proto message AtomicOfferInfo.
    
    - Add bool tradeAtomic field to CreateCryptoCurrencyPaymentAccountRequest.
    
    - Add trades service protos: GetAtomicTrade, TakeAtomicOffer.
    
    - Add proto message AtomicTradeInfo.
    ghubstan authored and sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    dce5b4c View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    cda293f View commit details
    Browse the repository at this point in the history
  29. Add atomic offer/trade proto wrappers

    ghubstan authored and sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    6ea8b88 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    0322830 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    bcdcc15 View commit details
    Browse the repository at this point in the history
  32. Add boolean isAtomicOffer() convenience

    ghubstan authored and sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    4b3adfc View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    b751f53 View commit details
    Browse the repository at this point in the history
  34. Support atomic payment method

    ghubstan authored and sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    83e8fd6 View commit details
    Browse the repository at this point in the history
  35. Add atomic offer/trade tests

    ghubstan authored and sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    9e4c0fb View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    068a845 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    b5cee9b View commit details
    Browse the repository at this point in the history
  38. Core: remove BTC trade fee option for atomic trades

    All trade fees are now paid using BSQ for atomic trades. The UI elements
    have still not been removed
    sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    e239425 View commit details
    Browse the repository at this point in the history
  39. Desktop: remove trade fee option from UI

    Clean up some copy paste residue from UI classes
    
    Remove unused AtomicModel
    sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    bec88fd View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    a534b4a View commit details
    Browse the repository at this point in the history
  41. Atomic funding

    sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    7fa31d9 View commit details
    Browse the repository at this point in the history
  42. AtomicOfferPayload: add hash

    sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    5b8dbac View commit details
    Browse the repository at this point in the history
  43. bitcoinj: update to better multi wallet handling

    Use bitcoinj version that clones incoming transactions.
    
    This fixes inconsistent wallet problems caused by bisq creating
    transactions with outputs going to both the BSQ and BTC wallets.
    sqrrm committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    02f980f View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. Rename OfferPayloadI to OfferPayloadBase

    chimp1984 authored and sqrrm committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    ca61054 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    834d0c8 View commit details
    Browse the repository at this point in the history
  3. Add BSQ_SWAP_OFFER capability

    We need to use capabilities to check if we can send a
    msg to the peer containing BSQ_Swap offer data.
    Added also support for BundleOfEnvelopes in the
    noCapabilityRequiredOrCapabilityIsSupported method and
    refactored the method.
    chimp1984 authored and sqrrm committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    65aa2e7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    76cb61d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    df88ef7 View commit details
    Browse the repository at this point in the history
  6. Remove handling for bundledEnvelopes in send method

    The code was never executed as it is not usual that on
    one connection multiple messages are sent in a short period.
    The handling for bundledEnvelopes has been implemented later
    into the broadcast domain, there is does do its job.
    chimp1984 committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    6993996 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c447d14 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5c8f46c View commit details
    Browse the repository at this point in the history
  9. Rename AtomicAccountPayload to BsqSwapAccountPayload

    Remove generic_string (was not used)
    chimp1984 committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    13b849f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    77b6508 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c89e005 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    13bdf2d View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a717cfc View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    1f0f616 View commit details
    Browse the repository at this point in the history
  15. Remove unused params

    chimp1984 committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    f022d70 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    8e6a428 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    914aaec View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    2d92651 View commit details
    Browse the repository at this point in the history
  19. Move bisq.core.trade.atomic.AtomicTxBuilder to bisq.core.btc.AtomicTx…

    …Builder
    
    As it is about transaction domain I think it fits better in the bitcoin domain
    chimp1984 committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    f9bbb61 View commit details
    Browse the repository at this point in the history
  20. Rename AtomicTxBuilder to BsqSwapTxHelper

    Builder would suggest the builder pattern, so maybe
    better use helper.
    chimp1984 committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    46b1a0f View commit details
    Browse the repository at this point in the history
  21. Rename AtomicMakerProtocol to BsqSwapMakerProtocol

    and AtomicTakerProtocol to BsqSwapTakerProtocol
    chimp1984 committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    b683664 View commit details
    Browse the repository at this point in the history
  22. Move bisq.core.trade.protocol.BsqSwapProtocolModel to bisq.core.trade…

    ….atomic.protocol.BsqSwapProtocolModel
    chimp1984 committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    d856544 View commit details
    Browse the repository at this point in the history
  23. Move trade model classes to bisq.core.trade.model package

    Keep bsqSwap and normal trade separate. Leave common classed
    in base package.
    No good name yet for default trade (default cannot be used as package name)
    chimp1984 committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    2388bd4 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    d94e633 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    39866b0 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    c081281 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    20effc7 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    e711378 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    75b1c7c View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    5f65f41 View commit details
    Browse the repository at this point in the history
  31. Remove Atomic prefixes for tasks

    The package should be enough to qualify them as
    BsqSwap tasks. They are only used in the limited scope
    of the protocol package.
    chimp1984 committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    50b78b1 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    ceacbb7 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    3b8d947 View commit details
    Browse the repository at this point in the history
  34. Rename views

    chimp1984 committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    4100af0 View commit details
    Browse the repository at this point in the history
  35. Rename AtomicOfferFunding

    chimp1984 committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    52a022c View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    40e4582 View commit details
    Browse the repository at this point in the history
  37. Replace TransactionResultHandler with Runnable

    There is no tx set at bsqSwap place offer protocol
    chimp1984 committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    19b0524 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    7853f26 View commit details
    Browse the repository at this point in the history
  39. Use OfferPayloadBase instead of ProtectedStoragePayload as type

    As we are in the offer domain we should use the domain relevant type.
    chimp1984 committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    fea0018 View commit details
    Browse the repository at this point in the history
  40. Remove redundant OfferPayload.Direction

    Move Direction one level up and rename to OfferDirection
    to match protobuf definition
    chimp1984 committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    a4059b4 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    b390743 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Configuration menu
    Copy the full SHA
    163bcce View commit details
    Browse the repository at this point in the history
  2. Refactor BsqSwapWalletWatcher and OpenOfferManager

    I think the dependency should be inverted here, so that the
    OpenOfferManager does not know about the details about BsqSwap
    funding.
    Removed FundingListener, use listener on observable list instead
    and maintain a filtered list in the BsqSwapWalletWatcher.
    chimp1984 committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    cb81c6f View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2021

  1. Configuration menu
    Copy the full SHA
    088b85b View commit details
    Browse the repository at this point in the history
  2. Fix copy paste error

    chimp1984 committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    7c74073 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2021

  1. Merge pull request #9 from chimp1984/Bsq-swap-3

    Bisq-swap-3
    sqrrm committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    c4e129b View commit details
    Browse the repository at this point in the history
  2. Add common interface for tradePeer.

    Move TradingPeer to trade package.
    
    Only stub now...
    chimp1984 committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    7872dbc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0354017 View commit details
    Browse the repository at this point in the history
  4. Add generics for TradePeer

    chimp1984 committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    f9d384c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3cc549b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    78ddc2d View commit details
    Browse the repository at this point in the history
  7. Add the 4 variants to trade and protocols

    Comment out all existing code in protocol domain. Will get re-added step by step...
    chimp1984 committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    503a065 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2021

  1. Trade protocol update according to other trade protocol

    - Follow the buyer/seller and maker/taker perspectives
      according to the domain context
    - Use the protocol model only for state data required as
      shared model for the tasks
    - Add a tradePeer model for holding the peers data
    - Keep logic in tasks and use a util class for re-used methods
    chimp1984 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    739811c View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. Configuration menu
    Copy the full SHA
    7022505 View commit details
    Browse the repository at this point in the history
  2. Cleanups

    chimp1984 committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    d77127d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    76982ff View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cadef15 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    82d05dd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8167d6d View commit details
    Browse the repository at this point in the history
  7. Move package bisq.core.trade.messages to bisq.core.trade.protocol.mes…

    …sages
    
    As messages are part of the protocol its better inside the protocol package
    chimp1984 committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    063dc93 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b432110 View commit details
    Browse the repository at this point in the history
  9. Remove references from multisigbased trade domain from generic trade …

    …classes
    
    Use interfaces for state and phase
    chimp1984 committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    011c929 View commit details
    Browse the repository at this point in the history
  10. Use concrete state/phase in impl classes

    Cleanups
    chimp1984 committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    7a5ba91 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    8a2fdb0 View commit details
    Browse the repository at this point in the history
  12. Use Trade as type in tradableList

    Make delegates to bsqSwapTradeManager more explicit
    Cleanup stream concats
    Add BsqTradeDetailsWindow instead using OfferDetailsWindow
    (not impl. changes yet in window)
    chimp1984 committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    853848d View commit details
    Browse the repository at this point in the history
  13. Remove offer only once trade is completed (tx visisble if maker is se…

    …ller)
    
    Pass bsqWalletService to getTransaction as provider is not set for
    closed trades but we want to access it in views.
    chimp1984 committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    1819356 View commit details
    Browse the repository at this point in the history
  14. Rename classes

    chimp1984 committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    0f8d1c9 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    030cff8 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    1f5f844 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    6a3c3a1 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    9a36329 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. Configuration menu
    Copy the full SHA
    b45211e View commit details
    Browse the repository at this point in the history
  2. Rename BsqSwapWalletWatcher to BsqSwapOfferManager

    Fix params in test
    chimp1984 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    07cdf70 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5b51fd7 View commit details
    Browse the repository at this point in the history
  4. Add fee listener

    chimp1984 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    63f2d25 View commit details
    Browse the repository at this point in the history
  5. Use Singleton annotation

    chimp1984 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    499302b View commit details
    Browse the repository at this point in the history
  6. Let BsqSwapAccountPayload extend PaymentAccountPayload

    We do not use an address but use that account only as
    proxy for marking Bsq Swaps
    chimp1984 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    6700ca6 View commit details
    Browse the repository at this point in the history
  7. Add comment

    chimp1984 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    aa83e5b View commit details
    Browse the repository at this point in the history
  8. Increase fee tolerance.

    Fee can be quite volatile so we allow larger deviations
    chimp1984 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    fa0853a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4da55ea View commit details
    Browse the repository at this point in the history
  10. Add getBsqTradeAmount to BsqSwapCalculation

    Use that method in BsqTrade.getBsqTradeAmount()
    chimp1984 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    303b536 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3e8357a View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    45b9921 View commit details
    Browse the repository at this point in the history
  13. Add todo

    chimp1984 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    827d603 View commit details
    Browse the repository at this point in the history
  14. Add comment

    chimp1984 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    a2fcaa0 View commit details
    Browse the repository at this point in the history
  15. Refactor tx creation and verification

    Add message with finalized tx to be sent to seller.
    Add Publish tx task to sellers side (only dont if
    tx not already received)
    chimp1984 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    725b8eb View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    9242ab9 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    3592625 View commit details
    Browse the repository at this point in the history
  18. Cleanups

    chimp1984 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    bb64320 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2021

  1. Configuration menu
    Copy the full SHA
    e44a431 View commit details
    Browse the repository at this point in the history
  2. Remove unused methods

    chimp1984 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    fd56eef View commit details
    Browse the repository at this point in the history
  3. Add scriptTypeId to RawTransactionInput

    We will need that to know if its a segwit input or not.
    Add constructors for converting a TransactionInput to
    RawTransactionInput. Handle bitcoinSerialize according
    to segwit flag.
    
    This change should not break anything as we only add a
    field to protobuf and RawTransactionInput is not used in
    cases where we depend on the hash of the payload like in
    offers.
    chimp1984 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    9e109ce View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8dc34c0 View commit details
    Browse the repository at this point in the history
  5. Remove unused methods

    chimp1984 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    efc5d0b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    095d780 View commit details
    Browse the repository at this point in the history
  7. Move getRawInputFromTransactionInput to TradeWalletService

    Don't change old behaviour for normal trade protocol methods
    where we use segwit=false for serialisation.
    chimp1984 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    4e70e5b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    73b897a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8e308e6 View commit details
    Browse the repository at this point in the history
  10. Fix check for segwit.

    transactionInput.hasWitness would only work for signed
    inputs but we need to do the fee calculation before the signing.
    
    Adjust fee calculation values using vbytes
    according to https://bitcoin.stackexchange.com/questions/87275/how-to-calculate-segwit-transaction-fee-in-bytes
    chimp1984 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    138fa2a View commit details
    Browse the repository at this point in the history
  11. Add handling for InsufficientMoneyException

    This need to be tested further...
    chimp1984 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    b4c1b4e View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    9858c26 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    2e80f18 View commit details
    Browse the repository at this point in the history
  14. Store sellersBsqPayoutAmount in protocolModel.setPayout

    at process input task and reuse that value in next task
    chimp1984 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    0550fda View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    b53c544 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    a266db8 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    aec5608 View commit details
    Browse the repository at this point in the history
  18. Fix handling for slightly overpaid BTC funds

    If available funds is < dust it will add the dust change to miner fee
    If the If available funds is > dust but the additional change output
    would produce another dust change it will also add it to miner fees.
    In that case the added amount is > dust.
    chimp1984 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    0e54439 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2021

  1. Add address validation

    chimp1984 committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    f5e19c0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b799f9 View commit details
    Browse the repository at this point in the history
  3. Update protocol description

    chimp1984 committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    13adb3a View commit details
    Browse the repository at this point in the history
  4. Rename methods and params

    chimp1984 committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    0a09bc0 View commit details
    Browse the repository at this point in the history
  5. Add getParentTxId method

    Cleanup, make constructors private and
    add deprecated annotation
    chimp1984 committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    5981863 View commit details
    Browse the repository at this point in the history
  6. Use getParentTxId method

    chimp1984 committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    4c13087 View commit details
    Browse the repository at this point in the history
  7. Use isDust

    chimp1984 committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    7c1c93e View commit details
    Browse the repository at this point in the history
  8. Add getUnspentTxOutputValue method

    Verify also sum of input values from DAO state data
    chimp1984 committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    f0fc08f View commit details
    Browse the repository at this point in the history
  9. Handle dust in caller

    Add comments
    chimp1984 committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    30d025a View commit details
    Browse the repository at this point in the history
  10. Merge pull request #16 from chimp1984/Complete-trade-protocol

    Complete trade protocol
    sqrrm committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    9c7bdf3 View commit details
    Browse the repository at this point in the history