Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TradeStatistics validation #5853

Merged
merged 6 commits into from Nov 23, 2021
Merged

Improve TradeStatistics validation #5853

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b6b2d93
Only apply maxTradeLimit from PaymentMethod if the PaymentMethod is
chimp1984 Nov 22, 2021
9d52ddb
Add warn log
chimp1984 Nov 22, 2021
9569e5a
Rename getActivePaymentMethodById to getActivePaymentMethod
chimp1984 Nov 22, 2021
091f824
Rename getPaymentMethod to getPaymentMethodId
chimp1984 Nov 22, 2021
cb474c5
Rename getPaymentMethodById to getPaymentMethod
chimp1984 Nov 22, 2021
0e10308
Simplify warn logging
ripcurlx Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/bisq/core/trade/statistics/TradeStatistics3.java
View file
Open in desktop
Expand Up @@ -444,7 +444,7 @@ public boolean isValid() {
maxTradeLimit = optionalPaymentMethod.get().getMaxTradeLimitAsCoin(currency).value;
}
} catch (Exception e) {
log.warn("Error at isValid(). " + e.toString(), e);
log.warn("Error at isValid().", e);
}
chimp1984 marked this conversation as resolved.
Show resolved Hide resolved
return amount > 0 &&
amount <= maxTradeLimit &&
Expand Down