Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a snippet to actually install the lfs package after adding the repository with the quick curl command #5869

Merged
merged 4 commits into from Dec 20, 2021

Conversation

w0000000t
Copy link
Contributor

Fixes #replaceWithIssueNr, fixes #replaceWithIssueNr

Your PR description here.

@boring-cyborg
Copy link

boring-cyborg bot commented Nov 26, 2021

Thanks for opening this pull request!

Please check out our contributor checklist and check if Travis or Codacy found any issues with your PR. Also make sure your commits are signed, and that you applied Bisq's code style and formatting.

A maintainer will add an is:priority label to your PR if it is up for compensation. Please see our Bisq Q1 2020 Update post for more details.

@ripcurlx
Copy link
Contributor

@w0000000t But isn't that explained on https://git-lfs.github.com/ on how to install git lfs in the LInk "Install v3.02 via PackageCloud (Linux)? Also your solution would only work on Linux and not on all other supported platforms. Or was that the problem, that you followed the guide on the git lfs page and it didn't work for you in the end?

@w0000000t
Copy link
Contributor Author

Hello, and thank you for getting back to me.
I did follow that link, which on my Linux VM brought me to https://packagecloud.io/github/git-lfs/install
There, I used the oneliner provided for the deb quick install, yet after that I got the error message as per my PR.
I had to improvise for a while and at the end thought of manually running the apt command first to search for a lfs package and then to actually get lfs installed, that is the reason I thought it might be useful to include my findings in the repo.

@ripcurlx
Copy link
Contributor

Hello, and thank you for getting back to me. I did follow that link, which on my Linux VM brought me to https://packagecloud.io/github/git-lfs/install There, I used the oneliner provided for the deb quick install, yet after that I got the error message as per my PR. I had to improvise for a while and at the end thought of manually running the apt command first to search for a lfs package and then to actually get lfs installed, that is the reason I thought it might be useful to include my findings in the repo.

Sorry for my late reply on this. Maybe add the note on which OSes this workaround would fix the issue (it is obvious for most, but probably good to mention it anyways)

@w0000000t
Copy link
Contributor Author

Sorry for my late reply on this. Maybe add the note on which OSes this workaround would fix the issue (it is obvious for most, but probably good to mention it anyways)

I have very limited GH skills, and only ever access its functions from the web UI, so I should have made the requested updates, please let me know if something is amiss

@ripcurlx
Copy link
Contributor

@w0000000t Yes, Git/GitHubs workflow can be overwhelming in the beginning. For the future to improve your commit messages please have a look at @cbeams article on git commit messages: https://cbea.ms/git-commit/

For this time I'll squash your commits into one during the merge.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ripcurlx ripcurlx merged commit 7b03e20 into bisq-network:master Dec 20, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 20, 2021

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants