Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect start height for block request #5875

Merged
merged 2 commits into from
Dec 6, 2021

Commits on Nov 27, 2021

  1. Fix incorrect start height for block request

    We added 1 as with the lite monitor mode we persist the most recent block,
    thus we request with the start height for the next block.
    But that cause a problem at a DAO full mode which has lite monitor mode set
    as then the block parsing would not be triggered.
    
    We refactor it so that we take the chainHeight from the dao state
    directly and add 1 at the requests.
    We add a check if we are at chain tip, and if so we skip requests
    and call the onParseBlockChainComplete directly.
    chimp1984 committed Nov 27, 2021
    Configuration menu
    Copy the full SHA
    bfd45d3 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2021

  1. Fix handling for genesis height and case when wallet sync is not comp…

    …leted yet.
    
    - At genesis we use the genesis height for request (not height+1)
    - If wallet is not synced yet we do not call onParseBlockChainComplete (as it was before)
    chimp1984 committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    c9e0265 View commit details
    Browse the repository at this point in the history