Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an intent to fight the messaging issues. We had in the past sometimes issues that Tor became instable and deleting the tor directory (excluding the hidden service dir) solved that. So it might be worth to see if it helps if we reset at each startup the tor directory.
The startup time for Tor is a bit slower as it need to download about 10MB of data.
Tests showed that it takes about 8 seconds longer. On a slow internet connection its about 15-25 sec slower.
I dont have a very strong opinion if we should use that PR as the chances that it fixes the problem are not super high, but its a relatively cheap attempt which comes with only a small delay at startup. Give a thumbs up/down if you support that PR.
I researched also to find if there are reported bugs with corrupted/outdated tor data but could not find much beside that at shutdown the decriptor files might get corrupted, but I assume that would lead to problems as starting Tor.
Normal:
With that PR: