Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve shutdown process #5905

Merged
merged 4 commits into from
Dec 8, 2021
Merged

Improve shutdown process #5905

merged 4 commits into from
Dec 8, 2021

Commits on Dec 8, 2021

  1. Do not shut down networkNode and Tor in parallel as network node 

    requires still tor when sending close messages.
Reduce timeout from 5 sec to 2 sec.
Reduce timeout for executor shutdown from 500 ms to 100 ms
    @chimp1984
    chimp1984 committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    a7c8f2d View commit details
    Browse the repository at this point in the history

  2. Extract duplicated code at shutdown 

    Move timeout before shutdown sequence starts and use a Timer thread instead of
UserThread to avoid that in case the UserThread gets blocked that the timeout
would not get triggered.
Reduce timeout from 20 sec. to 10 sec.
    @chimp1984
    chimp1984 committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    4eb14fb View commit details
    Browse the repository at this point in the history

  3. Reduce timeouts 

    Add logs when shutdown starts
    @chimp1984
    chimp1984 committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    2474e0d View commit details
    Browse the repository at this point in the history

  4. Add null checks 

    Return early at connection if stopped
Cleanup logs
    @chimp1984
    chimp1984 committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    3d40b3b View commit details
    Browse the repository at this point in the history